From: Frans Pop <elendil@planet.nl>
To: Greg KH <gregkh@suse.de>
Cc: Yinghai Lu <yhlu.kernel@gmail.com>, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [2.6.25-rc1] System no longer powers off after shutdown
Date: Fri, 15 Feb 2008 11:19:20 +0100 [thread overview]
Message-ID: <200802151119.23325.elendil@planet.nl> (raw)
In-Reply-To: <20080215065746.GA8916@suse.de>
On Friday 15 February 2008, Greg KH wrote:
> I swear someone sent this patch in before. Can you try this one below,
> there seems to be an imbalance with kobject_get and _put.
I did remember seeing this patch before [1] and can confirm that it does
indeed fix the issue: with this patch applied to 2.6.25 git head my system
powers off correctly.
[1] See http://lkml.org/lkml/2008/2/8/342; also added to #9960.
> ---
> drivers/cpufreq/cpufreq.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -1006,14 +1006,6 @@ static int __cpufreq_remove_dev (struct
> }
> #endif
>
> -
> - if (!kobject_get(&data->kobj)) {
> - spin_unlock_irqrestore(&cpufreq_driver_lock, flags);
> - cpufreq_debug_enable_ratelimit();
> - unlock_policy_rwsem_write(cpu);
> - return -EFAULT;
> - }
> -
> #ifdef CONFIG_SMP
>
> #ifdef CONFIG_HOTPLUG_CPU
next prev parent reply other threads:[~2008-02-15 10:19 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-11 15:23 [2.6.25-rc0 System no longer powers off after shutdown Frans Pop
2008-02-12 20:39 ` [2.6.25-rc1] " Frans Pop
2008-02-12 20:56 ` Greg KH
2008-02-12 21:45 ` Frans Pop
2008-02-13 7:54 ` Andrew Morton
2008-02-13 8:23 ` Jeff Chua
2008-02-13 9:24 ` Frans Pop
2008-02-13 11:39 ` Frans Pop
2008-02-13 16:58 ` Greg KH
2008-02-13 18:55 ` Rafael J. Wysocki
2008-02-15 6:59 ` Greg KH
2008-02-15 8:52 ` Jeff Chua
2008-02-15 21:00 ` Greg KH
2008-02-13 19:28 ` Frans Pop
2008-02-14 23:38 ` Yinghai Lu
2008-02-14 23:48 ` Ingo Molnar
2008-02-15 0:06 ` Yinghai Lu
2008-02-15 2:14 ` Yinghai Lu
2008-02-15 3:45 ` Yinghai Lu
2008-02-15 6:52 ` Greg KH
2008-02-15 8:41 ` Yinghai Lu
2008-02-15 20:58 ` Greg KH
2008-02-15 6:57 ` Greg KH
2008-02-15 10:19 ` Frans Pop [this message]
2008-02-15 19:38 ` Yinghai Lu
2008-02-15 20:31 ` Yinghai Lu
2008-02-15 20:58 ` Greg KH
2008-02-15 20:58 ` Greg KH
2008-02-13 8:41 ` [2.6.25-rc1] jerky mouse cursor and randoooom key repeats Frans Pop
2008-02-15 23:58 ` Pavel Machek
2008-02-16 1:23 ` Gabriel C
2008-02-16 6:19 ` Mike Galbraith
2008-02-16 10:09 ` Gabriel C
2008-02-16 14:03 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802151119.23325.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=gregkh@suse.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox