Re: [PATCH 4/6] h8300 CONFIG_KALLSYMS fix

[Andrew Morton <akpm@linux-foundation.org>]

On Sat, 16 Feb 2008 01:13:47 -0500 Yoshinori Sato <ysato@users.sourceforge.jp> wrote:

> Please comment "C_SYMBOL_PREFIX".
> 
>  Makefile           |    3 ++-
>  arch/h8300/Kconfig |    4 ++++
>  2 files changed, 6 insertions(+), 1 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index c162370..745e31f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -751,7 +751,8 @@ endef
>  # Generate .S file with all kernel symbols
>  quiet_cmd_kallsyms = KSYM    $@
>        cmd_kallsyms = $(NM) -n $< | $(KALLSYMS) \
> -                     $(if $(CONFIG_KALLSYMS_ALL),--all-symbols) > $@
> +                     $(if $(CONFIG_KALLSYMS_ALL),--all-symbols) \
> +                     $(if $(CONFIG_C_SYMBOL_PREFIX),--symbol-prefix='_') > $@
>  
>  .tmp_kallsyms1.o .tmp_kallsyms2.o .tmp_kallsyms3.o: %.o: %.S scripts FORCE
>  	$(call if_changed_dep,as_o_S)
> diff --git a/arch/h8300/Kconfig b/arch/h8300/Kconfig
> index 085dc6e..2804edd 100644
> --- a/arch/h8300/Kconfig
> +++ b/arch/h8300/Kconfig
> @@ -87,6 +87,10 @@ config HZ
>  	int
>  	default 100
>  
> +config C_SYMBOL_PREFIX
> +	bool
> +	default y
> +
>  source "init/Kconfig"
>  
>  source "arch/h8300/Kconfig.cpu"
> -- 

Sam looks after that code.

None of these patches added your Signed-off-by:.  Please confirm that it
is OK if I add it.