Re: [PATCH 07/30] r/o bind mounts: stub functions

Andrew Morton
2008-02-16T06:52:24Z

On Sat, 16 Feb 2008 07:31:29 +0100 Christoph Hellwig <hch@lst.de> wrote:

> On Fri, Feb 15, 2008 at 05:11:19PM -0800, Andrew Morton wrote:
> > > It would be nice if an initial patch which introduces the new
> > > functionality you need for r/o bind mounts could get introduced into
> > > mainline *first*, and then people could add patches that call
> > > mnt_want_write(), et. al into their trees gradually.
> >
> > Yes, I expect that merging a handful of do-nothing mnt_foo_write()
> > functions into mainline right now would ease life.
> >
> > > otherwise akpm gets grumpy
> >
> > itym "less than usually cheery"
>
> Haha,
>
> once we put pieces in the first three patches would be useful aswell,
> to easily catch additions in the next cycle that might be adding
> NULL-vfsmount calls to dentry_open.

hrm, well, how about putting up a complete and suitably-changelogged patch
series for Linus to look at? That's be a Dave thing I guess.

I wasn't overawed by the initial patch - why not make those stubs inlined
to truly add zero cost??