From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Harvey Harrison <harvey.harrison@gmail.com>,
Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] sched: trivial sparse warning in sched.c
Date: Sun, 17 Feb 2008 11:38:01 +0300 [thread overview]
Message-ID: <20080217083801.GA6752@cvg> (raw)
In-Reply-To: <1203198314.6298.6.camel@lappy>
[Peter Zijlstra - Sat, Feb 16, 2008 at 10:45:14PM +0100]
|
| On Sun, 2008-02-17 at 00:27 +0300, Cyrill Gorcunov wrote:
| > [Peter Zijlstra - Sat, Feb 16, 2008 at 10:11:29PM +0100]
| > |
[...]
| >
| > Hi Peter,
| >
| > dont you find 'return (void)foo();' statement a bit strange (as it was in
| > original code)? ;) Am I wrong? /it's night here, so half a brain already
| > tuned off ;)/
|
| void foo(void);
|
| void bar(void)
| {
| return foo();
| }
|
| Maybe I'm just weird an twisted, but no, I don't find it odd. In my mind
| its consistent with how all other return types function.
|
| Not sure what the C std text says on the matter though.
|
|
well, i've an obscure feeling about that. From one side I do understand that
you're *absolutely right* but the second form of statement is more clear
methink. That is what I prefer personally. Anyway the form of writting
such a statement is taste of code author - so you choose ;)
- Cyrill -
prev parent reply other threads:[~2008-02-17 8:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-15 17:56 [PATCH 2/3] sched: trivial sparse warning in sched.c Harvey Harrison
2008-02-16 21:11 ` Peter Zijlstra
2008-02-16 21:27 ` Cyrill Gorcunov
2008-02-16 21:45 ` Peter Zijlstra
2008-02-17 8:38 ` Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080217083801.GA6752@cvg \
--to=gorcunov@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox