Re: [patch 2/2] x86: lds - Use THREAD_SIZE instead of numeric constant

Cyrill Gorcunov
2008-02-17T20:16:33Z

[H. Peter Anvin - Sun, Feb 17, 2008 at 12:11:45PM -0800]
> Cyrill Gorcunov wrote:
>> Thanks Peter for comments. Peter could you clarify for me a bit
>> more on the string:
>> x86/kernel/head_32.S:339
>> /* Set up the stack pointer */
>> lss stack_start,%esp
>> but stack_start is defined as head_32.S:647
>> .data
>> ENTRY(stack_start)
>> .long init_thread_union+THREAD_SIZE
>> so stack_start *must* be aligned with THREAD_SIZE in vmlinux.lds
>> at compiling time. There is no PDA at this booting time. Am I wrong?
>> If you're too busy - just reply me like "Read the code" ;)
>
> That doesn't follow.
>
> You're saying that it *must* be aligned, I don't think that's true anymore;
> I think nowadays it's more accurate to say that it *is* aligned, but I
> don't think that's fundamental.
>
> -hpa
>

Thanks a lot, Peter.

- Cyrill -