From: Theodore Tso <tytso@MIT.EDU>
To: Julia Lawall <julia@diku.dk>
Cc: sct@redhat.com, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/7] fs/ext{2,3,4}: Use BUG_ON
Date: Sun, 17 Feb 2008 15:33:49 -0500 [thread overview]
Message-ID: <20080217203349.GH8905@mit.edu> (raw)
In-Reply-To: <Pine.LNX.4.64.0802171854270.28055@ask.diku.dk>
On Sun, Feb 17, 2008 at 06:55:06PM +0100, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> if (...) BUG(); should be replaced with BUG_ON(...) when the test has no
> side-effects to allow a definition of BUG_ON that drops the code completely.
Hi, in the future, please separate ext4 changes from ext2/3. Thanks!!
- Ted
prev parent reply other threads:[~2008-02-17 20:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-17 17:55 [PATCH 2/7] fs/ext{2,3,4}: Use BUG_ON Julia Lawall
2008-02-17 20:33 ` Theodore Tso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080217203349.GH8905@mit.edu \
--to=tytso@mit.edu \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sct@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox