From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "David P. Reed" <dpreed@reed.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, "David P. Reed" <dpreed@reed.com>
Subject: Re: [PATCH 1/3] x86: fix init_8259A() to not use outb_pic
Date: Sun, 17 Feb 2008 22:25:52 +0000 [thread overview]
Message-ID: <20080217222552.1af463b4@core> (raw)
In-Reply-To: <6gr00g$g7cm8h@smtp01.lnh.mail.rcn.net>
On Sun, 17 Feb 2008 16:56:28 -0500 (EST)
"David P. Reed" <dpreed@reed.com> wrote:
> fix init_8259A() which initializes the 8259 PIC to not use outb_pic,
> which is a renamed version of outb_p, and delete outb_pic define.
NAK
The entire point of inb_pic/outb_pic is to isolate the various methods
and keep the logic for delays in one place. Undoing this just creates a
nasty mess.
Quite probably inb_pic/outb_pic will end up as static inlines that do inb
or outb with a udelay of 1 or 2 but that is where the knowledge belongs.
next prev parent reply other threads:[~2008-02-17 22:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-17 21:56 [PATCH 1/3] x86: fix init_8259A() to not use outb_pic David P. Reed
2008-02-17 22:25 ` Alan Cox [this message]
2008-02-18 2:30 ` Rene Herman
2008-02-18 4:05 ` [linux-kernel] " David P. Reed
2008-02-18 10:37 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080217222552.1af463b4@core \
--to=alan@lxorguk.ukuu.org.uk \
--cc=dpreed@reed.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox