Re: [2.6 patch] fs/jbd/journal.c: cleanups

Adrian Bunk
2008-02-27T19:40:50Z

On Mon, Feb 18, 2008 at 08:28:58AM -0500, Theodore Tso wrote:
> On Mon, Feb 18, 2008 at 03:12:09PM +0200, Adrian Bunk wrote:
> > If me resending this old patch collides with something finally getting a
> > user this part of my patch shouldn't be applied now (but you might get
> > it again in 6 months if it's still unused...).
> >
> > But generally such conflicts would become visible if "known development
> > trees that are intended for mainline" were in -mm.
>
> It *has* been in -mm, except for periods when akpm has dropped it due
> to conflicts due to the "must have an in-tree user" doctrinaire
> attitude due to a conflict with the r/o bind patch.

OK, that's bad luck.

> Did you actually try to do a compile test, or only made sure the patch
> would apply? The patch won't collide at application time, but it
> would when you compile it....

Yes, I do test compilations of all of my patches.

But I don't have an overview of all development trees for all
subsystems.

> - Ted

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed