Re: [2.6 patch] fs/jbd/journal.c: cleanups

Andreas Dilger
2008-02-18T07:04:54Z

On Feb 17, 2008 10:19 +0200, Adrian Bunk wrote:
> This patch contains the following cleanups:
> - make the following needlessly global function static:
> - journal_check_used_features()
> - remove the following unused EXPORT_SYMBOL's:
> - journal_set_features
> - journal_update_superblock

Nack. I don't object to un-exporting journal_update_superblock(), because
that is pretty internal, but the other functions are intended specifically
for use by code outside of JBD. For example, the journal checksum patch for
ext3/4 uses journal_set_features() to turn on features in the JBD superblock.

Similarly, for 64-bit support in ext4 uses journal_set_features() to set
a 64-bit feature flag in the journal superblock.

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.