public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "David P. Reed" <dpreed@reed.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Rene Herman <rene.herman@keyaccess.nl>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: define outb_pic and inb_pic to stop using outb_p and inb_p
Date: Tue, 19 Feb 2008 10:42:56 +0100	[thread overview]
Message-ID: <20080219094256.GC7628@elte.hu> (raw)
In-Reply-To: <6gr00g$g7qpsd@smtp01.lnh.mail.rcn.net>


* David P. Reed <dpreed@reed.com> wrote:

> x86: define outb_pic and inb_pic to stop using outb_p and inb_p
>  
> The delay between io port accesses to the PIC is now defined using 
> outb_pic and inb_pic.  This fix provides the next step, using 
> udelay(2) to define the *PIC specific* timing requirements, rather 
> than on bus-oriented timing, which is not well calibrated.

thanks David, applied.

minor nit:

> +	/* delay for some accesses to PIC on motherboard or in chipset must be
> +	   at least one microsecond, but be safe here. */

i changed this to the standard multi-line comment style of:

> +	/*
> +      * Delay for some accesses to PIC on motherboard or in chipset 
> +      * must be at least one microsecond, but be safe here:
> +      */

	Ingo

      reply	other threads:[~2008-02-19  9:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-18 18:58 [PATCH] x86: define outb_pic and inb_pic to stop using outb_p and inb_p David P. Reed
2008-02-19  9:42 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080219094256.GC7628@elte.hu \
    --to=mingo@elte.hu \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=dpreed@reed.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rene.herman@keyaccess.nl \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox