From: Michael Buesch <mb@bu3sch.de>
To: "Gordon Farquharson" <gordonfarquharson@gmail.com>
Cc: "Sam Ravnborg" <sam@ravnborg.org>,
"Russell King" <rmk+lkml@arm.linux.org.uk>,
linux-kernel@vger.kernel.org, linville@tuxdriver.com,
stefano.brivio@polimi.it, "Linus Torvalds" <torvalds@osdl.org>,
"Andrew Morton" <akpm@osdl.org>,
viro@ftp.linux.org.uk
Subject: Re: [RFC] [PATCH] Fix b43 driver build for arm
Date: Tue, 19 Feb 2008 11:41:26 +0100 [thread overview]
Message-ID: <200802191141.26952.mb@bu3sch.de> (raw)
In-Reply-To: <97a0a9ac0802182059h36d32ac6o841bb0a1b766b74@mail.gmail.com>
On Tuesday 19 February 2008 05:59:21 Gordon Farquharson wrote:
> Does this thread [1] provide any clues as to the Right Thing (TM) to do?
>
> It should be noted that Linus and Andrew signed off on the m68k fix
> [2]. I'm CC'ing them and Al Viro on this email to solicit their input.
>
> Gordon
>
> [1] http://www.gossamer-threads.com/lists/linux/kernel/801528
> [2] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=7492d4a416d68ab4bd254b36ffcc4e0138daa8ff
>
That doesn't cause me to magically sign off this sort of patches, too.
The sanity check is clearly broken in file2alias.c, as it checks something
from the target kernel against the host environment it is compiled on.
That doesn't make any sense at all.
I also don't see why we want to compare the size of the struct in kernel
and userland. It is not used in userland.
So NACK for this SSB patch.
--
Greetings Michael.
next prev parent reply other threads:[~2008-02-19 10:42 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-18 22:03 [RFC] [PATCH] Fix b43 driver build for arm Gordon Farquharson
2008-02-18 22:08 ` Michael Buesch
2008-02-18 22:13 ` Russell King
2008-02-18 22:24 ` Michael Buesch
2008-02-18 22:34 ` Russell King
2008-02-18 22:43 ` Michael Buesch
2008-02-18 22:50 ` Harvey Harrison
2008-02-18 22:56 ` Michael Buesch
2008-02-18 22:53 ` Russell King
2008-02-18 23:00 ` Russell King
2008-02-18 23:17 ` Michael Buesch
2008-02-18 23:42 ` Sam Ravnborg
2008-02-19 0:01 ` Michael Buesch
2008-02-19 4:59 ` Gordon Farquharson
2008-02-19 10:41 ` Michael Buesch [this message]
2008-02-20 0:44 ` Gordon Farquharson
2008-02-20 14:44 ` Michael Buesch
2008-02-20 19:37 ` Sam Ravnborg
2008-02-22 4:24 ` Gordon Farquharson
2008-02-22 12:08 ` Gordon Farquharson
2008-02-22 14:07 ` Michael Buesch
2008-02-23 4:34 ` Gordon Farquharson
2008-02-23 5:51 ` Michael Buesch
2008-02-23 10:14 ` Gordon Farquharson
2008-02-23 15:58 ` Michael Buesch
2008-02-26 14:37 ` Ben Dooks
2008-02-26 16:12 ` Gordon Farquharson
2008-02-19 5:32 ` Sam Ravnborg
2008-02-22 13:13 ` Matthieu CASTET
2008-02-18 23:04 ` Michael Buesch
2008-02-19 8:37 ` Geert Uytterhoeven
2008-02-19 10:34 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802191141.26952.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=akpm@osdl.org \
--cc=gordonfarquharson@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=sam@ravnborg.org \
--cc=stefano.brivio@polimi.it \
--cc=torvalds@osdl.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox