From: "Ahmed S. Darwish" <darwish.07@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Tasklets: Avoid duplicating __tasklet_{,hi_}schedule() code
Date: Tue, 19 Feb 2008 18:27:18 +0200 [thread overview]
Message-ID: <20080219162718.GA3372@ubuntu> (raw)
In-Reply-To: <20080219155252.GA27280@elte.hu>
On Tue, Feb 19, 2008 at 04:52:52PM +0100, Ingo Molnar wrote:
>
> * Ahmed S. Darwish <darwish.07@gmail.com> wrote:
>
> > - local_irq_disable();
> > - t->next = __get_cpu_var(tasklet_vec).list;
> > - __get_cpu_var(tasklet_vec).list = t;
> > - __raise_softirq_irqoff(TASKLET_SOFTIRQ);
> > - local_irq_enable();
> > + /* We were not lucky enough to run, reschedule. */
> > + __tasklet_schedule(t);
>
> i think there's a subtle difference that you missed: this one does
> __raise_softirq_irqoff(), while __tasklet_schedule() does a
> raise_softirq_irqoff(). (note the lack of undescores)
>
> the reason is to avoid infinitely self-activating tasklets.
>
Indeed, thanks a lot for the explanation. (maybe it's time to check
for new eyeglasses ;)).
Regards
--
Ahmed S. Darwish
Homepage: http://darwish.07.googlepages.com
Blog: http://darwish-07.blogspot.com
next prev parent reply other threads:[~2008-02-19 16:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-19 15:37 [PATCH] Tasklets: Avoid duplicating __tasklet_{,hi_}schedule() code Ahmed S. Darwish
2008-02-19 15:52 ` Ingo Molnar
2008-02-19 16:27 ` Ahmed S. Darwish [this message]
2008-02-20 10:41 ` Ingo Molnar
2008-02-20 13:37 ` Ahmed S. Darwish
2008-02-20 14:20 ` Dmitry Adamushko
2008-02-20 19:39 ` Ahmed S. Darwish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080219162718.GA3372@ubuntu \
--to=darwish.07@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox