Re: [PATCH] sysv: [bl]e*_add_cpu conversion

Christoph Hellwig
2008-02-16T13:31:17Z

On Thu, Feb 14, 2008 at 02:04:37AM -0500, Christoph Hellwig wrote:
> > diff --git a/fs/sysv/sysv.h b/fs/sysv/sysv.h
> > index 42d51d1..38ebe3f 100644
> > --- a/fs/sysv/sysv.h
> > +++ b/fs/sysv/sysv.h
> > @@ -217,9 +217,9 @@ static inline __fs32 fs32_add(struct sysv_sb_info *sbi, __fs32 *n, int d)
> > if (sbi->s_bytesex == BYTESEX_PDP)
> > *(__u32*)n = PDP_swab(PDP_swab(*(__u32*)n)+d);
> > else if (sbi->s_bytesex == BYTESEX_LE)
> > - *(__le32*)n = cpu_to_le32(le32_to_cpu(*(__le32*)n)+d);
> > + le32_add_cpu((__le32 *)n, d);
> > else
> > - *(__be32*)n = cpu_to_be32(be32_to_cpu(*(__be32*)n)+d);
> > + be32_add_cpu((__be32 *)n, d);
> > return *n;
>
> but now that you've named the be and le primitives *_add_cpu it would
> be nice if you could submit a second patch to sysv to rename fs*_add
> to fs*_add_cpu aswell.

Btw, the same applies to ufs aswell as it's using the same construct.