Re: [PATCH] gfs2: be*_add_cpu conversion

Steven Whitehouse
2008-02-13T09:56:07Z

Hi,

Now in the GFS2 -nmw git tree. Thanks,

Steve.

On Wed, 2008-02-13 at 00:06 +0100, marcin.slusarz@gmail.com wrote:
> From: Marcin Slusarz <marcin.slusarz@gmail.com>
>
> replace all:
> big_endian_variable = cpu_to_beX(beX_to_cpu(big_endian_variable) +
> expression_in_cpu_byteorder);
> with:
> beX_add_cpu(&big_endian_variable, expression_in_cpu_byteorder);
> generated with semantic patch
>
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> Cc: Steven Whitehouse <swhiteho@redhat.com>
> Cc: cluster-devel@redhat.com
> ---
> fs/gfs2/dir.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c
> index c347095..6f2e382 100644
> --- a/fs/gfs2/dir.c
> +++ b/fs/gfs2/dir.c
> @@ -1021,13 +1021,13 @@ static int dir_split_leaf(struct inode *inode, const struct qstr *name)
>
> new->de_inum = dent->de_inum; /* No endian worries */
> new->de_type = dent->de_type; /* No endian worries */
> - nleaf->lf_entries = cpu_to_be16(be16_to_cpu(nleaf->lf_entries)+1);
> + be16_add_cpu(&nleaf->lf_entries, 1);
>
> dirent_del(dip, obh, prev, dent);
>
> if (!oleaf->lf_entries)
> gfs2_consist_inode(dip);
> - oleaf->lf_entries = cpu_to_be16(be16_to_cpu(oleaf->lf_entries)-1);
> + be16_add_cpu(&oleaf->lf_entries, -1);
>
> if (!prev)
> prev = dent;
> @@ -1616,7 +1616,7 @@ int gfs2_dir_add(struct inode *inode, const struct qstr *name,
> dent->de_type = cpu_to_be16(type);
> if (ip->i_di.di_flags & GFS2_DIF_EXHASH) {
> leaf = (struct gfs2_leaf *)bh->b_data;
> - leaf->lf_entries = cpu_to_be16(be16_to_cpu(leaf->lf_entries) + 1);
> + be16_add_cpu(&leaf->lf_entries, 1);
> }
> brelse(bh);
> error = gfs2_meta_inode_buffer(ip, &bh);