From: David Teigland <teigland@redhat.com>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Patrick Caulfield <pcaulfie@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dlm: match signedness between dlm_config_info and cluster_set
Date: Tue, 19 Feb 2008 13:47:23 -0600 [thread overview]
Message-ID: <20080219194723.GB5411@redhat.com> (raw)
In-Reply-To: <1202950469.18204.35.camel@brick>
On Wed, Feb 13, 2008 at 04:54:29PM -0800, Harvey Harrison wrote:
> cluster_set is only called from the macro CLUSTER_ATTR which defines read/write
> access functions. Make the signedness match to avoid sparse warnings every time
> CLUSTER_ATTR is used (lines 149-159) all of the form:
>
> fs/dlm/config.c:149:1: warning: incorrect type in argument 3 (different signedness)
> fs/dlm/config.c:149:1: expected unsigned int *info_field
> fs/dlm/config.c:149:1: got int extern [toplevel] *<noident>
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Thanks, added to dlm.git.
Dave
prev parent reply other threads:[~2008-02-19 19:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-14 0:54 [PATCH] dlm: match signedness between dlm_config_info and cluster_set Harvey Harrison
2008-02-19 19:47 ` David Teigland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080219194723.GB5411@redhat.com \
--to=teigland@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pcaulfie@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox