public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Yinghai Lu <Yinghai.Lu@Sun.COM>
To: Greg KH <greg@kroah.com>, Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/4] make dev_to_node return online node
Date: Wed, 20 Feb 2008 00:32:04 -0800	[thread overview]
Message-ID: <200802200032.04915.yinghai.lu@sun.com> (raw)
In-Reply-To: <200802200015.43547.yinghai.lu@sun.com>



some numa system ( with multi HT chains) may return node without ram. aka it
is not online.
try to get one online node.

Signed-off-by: Yinghai Lu <yinghai.lu@sun.com>

diff --git a/include/linux/device.h b/include/linux/device.h
index 2258d89..7f1a4d7 100644
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -478,7 +478,12 @@ struct device {
 #ifdef CONFIG_NUMA
 static inline int dev_to_node(struct device *dev)
 {
-	return dev->numa_node;
+	int node;
+	node = dev->numa_node;
+
+	if (node != -1 && !node_online(node))
+		node = numa_node_id();
+	return node;
 }
 static inline void set_dev_node(struct device *dev, int node)
 {

  reply	other threads:[~2008-02-20  8:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-20  8:15 [PATCH 0/4] make dev_to_node return online node or -1 Yinghai Lu
2008-02-20  8:32 ` Yinghai Lu [this message]
2008-02-20 20:41   ` [PATCH 1/4] make dev_to_node return online node Yinghai Lu
2008-02-20  8:34 ` [PATCH 3/4] ide: use dev_to_node instead of pcibus_to_node Yinghai Lu
2008-02-20  8:36 ` [PATCH 4/4] driver: use dev_to_node in pci_call_probe Yinghai Lu
2008-02-20  8:36 ` [PATCH 2/4] x86_64: fix dma_alloc_pages v2 Yinghai Lu
2008-02-20 10:07   ` Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802200032.04915.yinghai.lu@sun.com \
    --to=yinghai.lu@sun.com \
    --cc=akpm@linux-foundation.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox