From: Randy Dunlap <randy.dunlap@oracle.com>
To: lkml <linux-kernel@vger.kernel.org>
Cc: gregkh <greg@kroah.com>, akpm <akpm@linux-foundation.org>
Subject: [PATCH 2/2] firmware: fix a few build errors
Date: Wed, 20 Feb 2008 13:21:00 -0800 [thread overview]
Message-ID: <20080220132100.c168fc20.randy.dunlap@oracle.com> (raw)
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix one typo (comma to semi-colon).
Fix sysfs externs (just use sysfs.h for prototypes).
Documentation/firmware_class/firmware_sample_firmware_class.c:37: error: conflicting types for 'sysfs_remove_bin_file'
include/linux/sysfs.h:100: error: previous declaration of 'sysfs_remove_bin_file' was here
Still has a build error:
ERROR: "firmware_class" [samples/firmware_class/firmware_sample_firmware_class.ko]
undefined!
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
samples/firmware_class/firmware_sample_firmware_class.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
--- linux-2625-rc2-docsrc.orig/samples/firmware_class/firmware_sample_firmware_class.c
+++ linux-2625-rc2-docsrc/samples/firmware_class/firmware_sample_firmware_class.c
@@ -33,9 +33,6 @@ struct class_device_attribute *to_class_
return container_of(_attr,struct class_device_attribute,attr);
}
-int sysfs_create_bin_file(struct kobject * kobj, struct bin_attribute * attr);
-int sysfs_remove_bin_file(struct kobject * kobj, struct bin_attribute * attr);
-
struct firmware_priv {
char fw_id[FIRMWARE_NAME_MAX];
s32 loading:2;
@@ -127,7 +124,7 @@ static int fw_setup_class_device(struct
class_dev->class_id[BUS_ID_SIZE-1] = '\0';
class_dev->dev = device;
- class_dev->class = &firmware_class,
+ class_dev->class = &firmware_class;
class_set_devdata(class_dev, fw_priv);
retval = class_device_register(class_dev);
if (retval){
next reply other threads:[~2008-02-20 21:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-20 21:21 Randy Dunlap [this message]
2008-02-20 21:49 ` [PATCH 2/2] firmware: fix a few build errors Marcel Holtmann
2008-02-20 21:56 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080220132100.c168fc20.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox