From: Greg KH <greg@kroah.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: Andrew Patterson <andrew.patterson@hp.com>,
linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: pci/pcie/aer/aerdrv_acpi.c: inconsequent NULL checking
Date: Wed, 20 Feb 2008 08:09:35 -0800 [thread overview]
Message-ID: <20080220160935.GA2658@kroah.com> (raw)
In-Reply-To: <20080220075628.GD31955@cs181133002.pp.htv.fi>
On Wed, Feb 20, 2008 at 09:56:28AM +0200, Adrian Bunk wrote:
> On Tue, Feb 19, 2008 at 09:47:58PM -0800, Greg KH wrote:
> > On Tue, Feb 19, 2008 at 09:29:02PM +0200, Adrian Bunk wrote:
> > > The Coverity checker spotted the following inconsequent NULL checking
> > > introduced by commit 3c75e23784e6ed5f4841de43d0750fd9b37bafcb:
> > >
> > > <-- snip -->
> > >
> > > ...
> > > int aer_osc_setup(struct pcie_device *pciedev)
> > > {
> > > ... vvvvvvvvv
> > > while (pdev->bus && pdev->bus->self)
> > > pdev = pdev->bus->self;
> >
> > That could probably change to just pdev->bus->self, as a bus should
> > always be there for a pdev, so I don't see this as a problem.
>
> I'm not claiming this specific case was a problem.
Well, Coverity did :)
> When a NULL check is only performed in some cases that's sometimes a bug
> that has to be fixed and in most cases a not required check that should
> be removed at some point in time.
I agree, patches are always welcome...
thanks,
greg k-h
next prev parent reply other threads:[~2008-02-20 16:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-19 19:29 pci/pcie/aer/aerdrv_acpi.c: inconsequent NULL checking Adrian Bunk
2008-02-20 5:47 ` Greg KH
2008-02-20 7:56 ` Adrian Bunk
2008-02-20 16:09 ` Greg KH [this message]
2008-02-22 19:58 ` [2.6 patch] pci/pcie/aer/aerdrv_acpi.c: remove unneeded NULL check Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080220160935.GA2658@kroah.com \
--to=greg@kroah.com \
--cc=andrew.patterson@hp.com \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox