[QUESTION] FRV: linking error?

[QUESTION] FRV: linking error?

[Cyrill Gorcunov]

Hi David,

being see over vmlinux.lds for FRV architecture I found the string:

	. = ALIGN(4096);
	.data.page_aligned : { *(.data.idt) }

though the PAGE_SIZE is 16K. Can't figure out why is that...
Do you have a few spare minutes to explain, please?

		- Cyrill -

Re: [QUESTION] FRV: linking error?

[David Howells]

Cyrill Gorcunov <gorcunov@gmail.com> wrote:

> being see over vmlinux.lds for FRV architecture I found the string:
> 
> 	. = ALIGN(4096);
> 	.data.page_aligned : { *(.data.idt) }
> 
> though the PAGE_SIZE is 16K. Can't figure out why is that...
> Do you have a few spare minutes to explain, please?

Ummm...  Good question.  Probably a legacy thing.  I think the .data.idt
section is also an x86-only thing and should be dispensed with for FRV.
Leastways, the section has nothing in it according to the link map.

David

Re: [QUESTION] FRV: linking error?

[Sam Ravnborg]

On Wed, Feb 20, 2008 at 01:01:05PM +0000, David Howells wrote:
> Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> 
> > being see over vmlinux.lds for FRV architecture I found the string:
> > 
> > 	. = ALIGN(4096);
> > 	.data.page_aligned : { *(.data.idt) }
> > 
> > though the PAGE_SIZE is 16K. Can't figure out why is that...
> > Do you have a few spare minutes to explain, please?
> 
> Ummm...  Good question.  Probably a legacy thing.  I think the .data.idt
> section is also an x86-only thing and should be dispensed with for FRV.
> Leastways, the section has nothing in it according to the link map.

A quick grep agree with you.
I see it used only in x86 in traps_32 for the F0 0F bug.
It exist in several .lds files - including frv.

	Sam

Re: [QUESTION] FRV: linking error?

[Cyrill Gorcunov]

[Sam Ravnborg - Wed, Feb 20, 2008 at 02:14:42PM +0100]
| On Wed, Feb 20, 2008 at 01:01:05PM +0000, David Howells wrote:
| > Cyrill Gorcunov <gorcunov@gmail.com> wrote:
| > 
| > > being see over vmlinux.lds for FRV architecture I found the string:
| > > 
| > > 	. = ALIGN(4096);
| > > 	.data.page_aligned : { *(.data.idt) }
| > > 
| > > though the PAGE_SIZE is 16K. Can't figure out why is that...
| > > Do you have a few spare minutes to explain, please?
| > 
| > Ummm...  Good question.  Probably a legacy thing.  I think the .data.idt
| > section is also an x86-only thing and should be dispensed with for FRV.
| > Leastways, the section has nothing in it according to the link map.
| 
| A quick grep agree with you.
| I see it used only in x86 in traps_32 for the F0 0F bug.
| It exist in several .lds files - including frv.
| 
| 	Sam
| 

Sam, maybe we should just eliminate this section at least for FRV?

		- Cyrill -

Re: [QUESTION] FRV: linking error?

[Cyrill Gorcunov]

[David Howells - Wed, Feb 20, 2008 at 01:01:05PM +0000]
| Cyrill Gorcunov <gorcunov@gmail.com> wrote:
| 
| > being see over vmlinux.lds for FRV architecture I found the string:
| > 
| > 	. = ALIGN(4096);
| > 	.data.page_aligned : { *(.data.idt) }
| > 
| > though the PAGE_SIZE is 16K. Can't figure out why is that...
| > Do you have a few spare minutes to explain, please?
| 
| Ummm...  Good question.  Probably a legacy thing.  I think the .data.idt
| section is also an x86-only thing and should be dispensed with for FRV.
| Leastways, the section has nothing in it according to the link map.
| 
| David
| 
Oops ;) Thanks, David

		- Cyrill -

Re: [QUESTION] FRV: linking error?

[David Howells]

Cyrill Gorcunov <gorcunov@gmail.com> wrote:

> Sam, maybe we should just eliminate this section at least for FRV?

You should have a patch in your inbox to do just that.

David

Re: [QUESTION] FRV: linking error?

[Cyrill Gorcunov]

[David Howells - Wed, Feb 20, 2008 at 06:13:15PM +0000]
| Cyrill Gorcunov <gorcunov@gmail.com> wrote:
| 
| > Sam, maybe we should just eliminate this section at least for FRV?
| 
| You should have a patch in your inbox to do just that.
| 
| David
| 

Thanks David! I've got them all.
I think Sam will take care of them to be included in mainline.
Thanks.

		- Cyrill -

Re: [QUESTION] FRV: linking error?

[Sam Ravnborg]

On Wed, Feb 20, 2008 at 09:15:00PM +0300, Cyrill Gorcunov wrote:
> [David Howells - Wed, Feb 20, 2008 at 06:13:15PM +0000]
> | Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> | 
> | > Sam, maybe we should just eliminate this section at least for FRV?
> | 
> | You should have a patch in your inbox to do just that.
> | 
> | David
> | 
> 
> Thanks David! I've got them all.
> I think Sam will take care of them to be included in mainline.

arch stuff like this is preferably going via the arch maintainer.
Sometimes I do all-arch patches but when they are independent
like this one they should go via the arch maintainer.

Cyrill - I would like you to do the same cleanup for
m32r + mn10300 + s390
and send the patch to the respective maintainers with a cc to me.

Thanks,
	Sam

Re: [QUESTION] FRV: linking error?

[Cyrill Gorcunov]

[Sam Ravnborg - Wed, Feb 20, 2008 at 08:19:38PM +0100]
| On Wed, Feb 20, 2008 at 09:15:00PM +0300, Cyrill Gorcunov wrote:
| > [David Howells - Wed, Feb 20, 2008 at 06:13:15PM +0000]
| > | Cyrill Gorcunov <gorcunov@gmail.com> wrote:
| > | 
| > | > Sam, maybe we should just eliminate this section at least for FRV?
| > | 
| > | You should have a patch in your inbox to do just that.
| > | 
| > | David
| > | 
| > 
| > Thanks David! I've got them all.
| > I think Sam will take care of them to be included in mainline.
| 
| arch stuff like this is preferably going via the arch maintainer.
| Sometimes I do all-arch patches but when they are independent
| like this one they should go via the arch maintainer.
| 
| Cyrill - I would like you to do the same cleanup for
| m32r + mn10300 + s390
| and send the patch to the respective maintainers with a cc to me.
| 
| Thanks,
| 	Sam
| 

ok, I will do it

		- Cyrill -