* [PATCH] 68360serial: Note that there isn't any info->mcr locking
@ 2008-02-20 20:39 Alan Cox
0 siblings, 0 replies; only message in thread
From: Alan Cox @ 2008-02-20 20:39 UTC (permalink / raw)
To: akpm, linux-kernel
Noticed while auditing the code for the BKL elimination project
Signed-off-by: Alan Cox <alan@redhat.com>
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.25-rc2-mm1/drivers/serial/68360serial.c linux-2.6.25-rc2-mm1/drivers/serial/68360serial.c
--- linux.vanilla-2.6.25-rc2-mm1/drivers/serial/68360serial.c 2008-02-19 11:01:44.000000000 +0000
+++ linux-2.6.25-rc2-mm1/drivers/serial/68360serial.c 2008-02-20 11:52:17.000000000 +0000
@@ -1281,7 +1281,7 @@
if (tty->flags & (1 << TTY_IO_ERROR))
return -EIO;
-
+ /* FIXME: locking on info->mcr */
if (set & TIOCM_RTS)
info->mcr |= UART_MCR_RTS;
if (set & TIOCM_DTR)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-02-20 20:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-20 20:39 [PATCH] 68360serial: Note that there isn't any info->mcr locking Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox