From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric constant in boot code
Date: Thu, 21 Feb 2008 22:50:22 +0300 [thread overview]
Message-ID: <20080221195022.GA6772@cvg> (raw)
This patch replaces 4096 numeric constant with PAGE_SIZE macro.
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
Text segments of old and new files *are* the same so
it wouldn't break current kernel.
main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: linux-2.6.git/arch/x86/boot/main.c
===================================================================
--- linux-2.6.git.orig/arch/x86/boot/main.c 2008-02-09 22:27:13.000000000 +0300
+++ linux-2.6.git/arch/x86/boot/main.c 2008-02-21 22:28:10.000000000 +0300
@@ -14,6 +14,7 @@
* Main module for the real-mode kernel code
*/
+#include <asm/page.h>
#include "boot.h"
struct boot_params boot_params __attribute__((aligned(16)));
@@ -36,7 +37,7 @@ static void copy_boot_params(void)
const struct old_cmdline * const oldcmd =
(const struct old_cmdline *)OLD_CL_ADDRESS;
- BUILD_BUG_ON(sizeof boot_params != 4096);
+ BUILD_BUG_ON(sizeof boot_params != PAGE_SIZE);
memcpy(&boot_params.hdr, &hdr, sizeof hdr);
if (!boot_params.hdr.cmd_line_ptr &&
next reply other threads:[~2008-02-21 19:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 19:50 Cyrill Gorcunov [this message]
2008-02-21 19:52 ` [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric constant in boot code H. Peter Anvin
2008-02-21 19:56 ` Cyrill Gorcunov
2008-02-21 19:59 ` H. Peter Anvin
2008-02-21 20:00 ` Cyrill Gorcunov
2008-02-21 20:05 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080221195022.GA6772@cvg \
--to=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox