Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric constant in boot code

H. Peter Anvin
2008-02-21T20:00:00Z

> [H. Peter Anvin - Thu, Feb 21, 2008 at 11:52:56AM -0800]
>> Cyrill Gorcunov wrote:
>>> This patch replaces 4096 numeric constant with PAGE_SIZE macro.
>>> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
>>> ---
>>> Text segments of old and new files *are* the same so
>>> it wouldn't break current kernel.
>> NAK.
>>
>> This is NOT PAGE_SIZE (even though the two values are coincidentally the
>> same, for historical reasons.)
>>
>> -hpa
>>
>
> hmm, why the comment on boot_param structure definition calls
> it "zeropage"? Anyway really thanks for review and catched this.
>

Historical reasons... it used to be a "magic page" -- that's long since
gone.

-hpa