public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: David Newall <davidn@davidnewall.com>
Cc: Willy Tarreau <w@1wt.eu>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 2.4: Back-port of pl2303.c from 2.6.24.1
Date: Thu, 21 Feb 2008 12:36:40 -0800	[thread overview]
Message-ID: <20080221203640.GA21764@kroah.com> (raw)
In-Reply-To: <47BDDD4E.1080000@davidnewall.com>

On Fri, Feb 22, 2008 at 06:51:34AM +1030, David Newall wrote:
> Hi Willy,
> 
> Lacking hardware for a week, I've had a bit of a hiatus from PL2303, but
> I've got it back again now, and finished my work back-porting the 2.6
> driver to 2.4.  Here's a new patch, which is more complete than my
> previous one.  It's based on the 2.6.24.1.
> 
> There's a lot of trivial white-space changes and some things that have
> been moved, which make the patch rather larger than it could be.  I
> didn't include those changes before, but have now in order that the
> driver be closer to the 2.6 driver.  It'll never be identical, of course.
> 
> Note, too, that the 2.6 driver (and thus the patched 2.4) includes a 1k
> circular buffer which rather duplicates a buffer in the 2.4 usbserial.c;
> 2.6's usb-serial has had that buffer removed.  As the buffer resolves
> loss of the occasional putchar (e.g. from n_tty's opost), it is
> important and correct, even in 2.4.
> 
> Speaking as a user, I no longer see any problems with PL2303, and I
> think this is okay to release.

If this works for you, I have no objection to it, but I can't test it as
I don't run 2.4 on anything anymore :)

thanks,

greg k-h

  parent reply	other threads:[~2008-02-21 20:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-26  0:50 [PATCH] 2.4: Back-port of pl2303.c from 2.6.23.14 David Newall
2008-02-02  7:44 ` Willy Tarreau
2008-02-02 13:11   ` David Newall
2008-02-02 14:57     ` Willy Tarreau
2008-02-21 20:21     ` [PATCH] 2.4: Back-port of pl2303.c from 2.6.24.1 David Newall
2008-02-21 20:30       ` David Newall
2008-02-21 20:36       ` Greg KH [this message]
2008-02-21 21:00         ` Willy Tarreau
2008-02-21 21:33           ` Greg KH
2008-02-22  1:33             ` David Newall
2008-02-22 10:02               ` Willy Tarreau
2008-02-22 17:47                 ` Gene Heskett
2008-03-19 14:24                   ` David Newall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080221203640.GA21764@kroah.com \
    --to=greg@kroah.com \
    --cc=davidn@davidnewall.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox