From: Ingo Molnar <mingo@elte.hu>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: tglx@linutronix.de, mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] X86: don't print a warning when MTRR are blank and running in KVM
Date: Thu, 21 Feb 2008 21:37:48 +0100 [thread overview]
Message-ID: <20080221203748.GA9031@elte.hu> (raw)
In-Reply-To: <1203605414-4958-1-git-send-email-joerg.roedel@amd.com>
* Joerg Roedel <joerg.roedel@amd.com> wrote:
> - if (!highest_pfn) {
> + if (!highest_pfn && !kvm_para_available()) {
> printk(KERN_WARNING "WARNING: strange, CPU MTRRs all blank?\n");
> WARN_ON(1);
> - return 0;
> }
>
> + if (!highest_pfn)
> + return 0;
hm, why not have a single test for !highest_pfn:
if (!highest_pfn) {
if (!kvm_para_available()) {
printk(KERN_WARNING
"WARNING: strange, CPU MTRRs all blank?\n");
WARN_ON(1);
}
return 0;
}
? But yeah, your patch looks good otherwise.
I'm not sure how we could detect pure Qemu instances - perhaps it should
define some special MSR or something?
Ingo
next prev parent reply other threads:[~2008-02-21 20:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 14:50 [PATCH] X86: don't print a warning when MTRR are blank and running in KVM Joerg Roedel
2008-02-21 19:54 ` Yinghai Lu
2008-02-22 11:18 ` Joerg Roedel
2008-02-21 20:37 ` Ingo Molnar [this message]
2008-02-21 22:31 ` H. Peter Anvin
2008-02-22 9:45 ` Ingo Molnar
2008-02-22 9:58 ` H. Peter Anvin
2008-02-22 10:00 ` Ingo Molnar
2008-02-22 10:04 ` H. Peter Anvin
2008-02-22 11:15 ` Joerg Roedel
2008-02-22 12:48 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080221203748.GA9031@elte.hu \
--to=mingo@elte.hu \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox