Re: Regression [Was: Boot hang with stack protector on x86_64]

Arjan van de Ven
2008-02-22T15:59:55Z

On Fri, 22 Feb 2008 07:43:08 -0800 (PST)
Linus Torvalds <torvalds@linux-foundation.org> wrote:

>
>
> On Fri, 22 Feb 2008, Sam Ravnborg wrote:
> >
> > This is a regression. Can you please revert this commit.
>
> Not really. The thing is, CONFIG_CC_STACKPROTECTOR has never done
> anything at all, now it does, and it shows that it never worked.
>
> So the commit that made it do something shouldn't be reverted, but
> CONFIG_CC_STACKPROTECTOR should be marked BROKEN, because it
> obviously is broken right now.
>
> But keeping the config option, and just not making it do anything is
> misleading and wrong.
>
> So just something like this? To make sure normal people don't enable
> it..

looks fair; once the patches to make it work are merged the B0RKEN can
go away again easliy