Re: bcm43xx regression in 2.6.24 (with patch)

Alexey Zaytsev
2008-02-22T20:08:41Z

[replying from my non-work account]

On Fri, Feb 22, 2008 at 8:48 PM, Michael Buesch <mb@bu3sch.de> wrote:
> On Friday 22 February 2008 19:10:39 Alexey Zaytsev wrote:
> > Sorry, I don't get it. You are going to remove the (somehow)
> > working driver, while there are known problems with the new
> > one? Why?
>
> Because the new driver works, if you just set it up right.
> Until now every "breakage" was just a usage error.
>
>
> > And please look at the problem from a user's view point. I'm
> > happily using the 2.6.23 kernel. The bcm43xx driver is the
> > only one available. And it works somehow (well, no s2ram).
>
> b43 supports s2ram and s2disk.
>
>
> > If this is not a repgession, than I don't know what is.
> > And if it is a regression, it should be fixed at least in the
> > 2.6.24.y series, do you agree?
>
> No. Playing with kconfig SELECT is really _nothing_ for a -stable
> series. I am _not_ going to be responsible for any
> breakages. And using SELECT _does_ break things. We had dozens of bugs
> until all the damn dependencies were right. Even "Obviously Correct (tm)"
> changes to SELECT _do_ break on weird configurations.
> See the bcm43xx mail archives for examples.
>

Well, someone obviously played with the SELECTs, and broke the bcm43xx driver.
Now I've got a patch that I believe gets the SELECTs right and fixes
the driver, so
what is wrong?

> If you need that patch for some reason, please apply it locally.
> The problem will automatically get fixed when bcm43xx goes away, soon.
>
>
> > I have provided a patch that I believe is trivial, that I have
> > tested with all possible config option combinations I thought
> > were possible, and that fixes the regression. If you have a
> > reason to believe it is wrong, please say it, I won't be
> > offended. If there is a problem with the patch, I'll gladly
> > fix and resend it.
> >
> > This Nack leaves me with one option - to switch back to 2.6.23.
> > Sorry, no testing, probably more bugs not found in 2.6.24. ;(
>
> It is not my problem, if you refuse to use b43.
> You also still refuse to tell me details about your card and _what_
> does not work. I do own lots of different card and they
> all work fine with b43. There's one exception, the 4311 rev 3 (or something,
> don't quite remember). But patches are available and will ship in 2.6.25.
> bcm43xx won't get removed until that shipped.

Yes, it's a 4311 rev 01, but I'm probably was just too lame to upgrade the
firmware or something. :E

I really don't get it, what is going on here? You state that the new b32 driver
has problems on some hardware, where the old bcm43xx driver just works.
And at the same time, you are surprised that I "refuse" to use the b43 driver
and push patches for the bcm43xx driver you broke... Oh, really, why?!