Re: [Bug 10030] Suspend doesn't work when SD card is inserted

Alan Stern
2008-02-24T20:45:31Z

On Sun, 24 Feb 2008, Rafael J. Wysocki wrote:

> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> Remove the code that acquires all device semaphores from the suspend
> code path as it causes multiple problems to appear (most notably,
> http://bugzilla.kernel.org/show_bug.cgi?id=10030) and revert the
> change introduced by commit 4145ed6dc597a9bea5f6ae8c574653b2de10620f
> depending on the code being removed.
>
> Remove pm_sleep_lock()/pm_sleep_unlock() from device add to avoid
> the issue reported at http://bugzilla.kernel.org/show_bug.cgi?id=9874.

Do you actually know whether removing that lock fixes the reported bug?

I agree, the lock should be removed for now. But I'd sure like to get
some feedback about what's going wrong. It's starting to look as
though we'd be a lot better off blocking device registration during
sleep instead of failing it.

Shouldn't resume_device() and suspend_device() now acquire the device
semaphore before calling the various methods? That's the way they
used to work.

Alan Stern