Re: [Q] x86 - boot/header.S

Cyrill Gorcunov
2008-02-25T08:07:27Z

[H. Peter Anvin - Sun, Feb 24, 2008 at 06:15:52PM -0800]
> Cyrill Gorcunov wrote:
>> Hi Peter, Sam,
>> could you take a look on x86/boot/header.S:280 please?
>> # Zero the bss
>> movw $__bss_start, %di
>> movw $_end+3, %cx
>> xorl %eax, %eax
>> subw %di, %cx
>> shrw $2, %cx
>> rep; stosl
>> I wonder why is $_end there instead of $__bss_stop?
>> Well, accroding to vmlinux_32.lsd both _end and __bss_stop
>> are the same BUT __bss_stop is more convenient methink.
>> Would it be usefull to change?
>
> x86/boot/header.S goes with x86/boot/setup.ld and no other linker script.
>
> -hpa
>

indeed... :( anyway, setup.ld has the definition of __bss_stop too
though in this case __bss_stop is not equal to _end BUT
[__bss_start;__bss_stop] do cover *bss section anyway.

According to Sam's last post it will not be a problem anymore
'cause of memset further usage.

Thanks for comments, Peter.

- Cyrill -