From: Ingo Molnar <mingo@elte.hu>
To: Joe Perches <joe@perches.com>
Cc: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>,
hpa <hpa@zytor.com>, tglx <tglx@linutronix.de>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 20/20] x86: Coding Style fixes to arch/x86/xen/multicalls.c
Date: Sat, 23 Feb 2008 11:01:40 +0100 [thread overview]
Message-ID: <20080223100140.GA23833@elte.hu> (raw)
In-Reply-To: <1203720217.19319.99.camel@localhost>
* Joe Perches <joe@perches.com> wrote:
> > printk(KERN_ERR "%d multicall(s) failed: cpu %d\n",
> > ret, smp_processor_id());
> > - for(i = 0; i < b->mcidx; i++) {
> > + for (i = 0; i < b->mcidx; i++) {
> > printk(" call %2d/%d: op=%lu arg=[%lx] result=%ld\n",
>
> The printk needs a KERN_ERR prefix
yes - but we prefer to isolate the "does not change the .o in any way"
cleanups from cleanups that materially change kernel behavior. (such as
printing something else)
Ingo
prev parent reply other threads:[~2008-02-23 10:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-22 22:11 [PATCH 20/20] x86: Coding Style fixes to arch/x86/xen/multicalls.c Paolo Ciarrocchi
2008-02-22 22:43 ` Joe Perches
2008-02-23 10:01 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080223100140.GA23833@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.ciarrocchi@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox