From: Andrew Morton <akpm@linux-foundation.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Arjan van de Ven <arjan@infradead.org>,
linux-kernel@vger.kernel.org, sandmann@redhat.com, tglx@tglx.de,
hpa@zytor.com, John Levon <levon@movementarian.org>
Subject: Re: [PATCH] x86: add the debugfs interface for the sysprof tool
Date: Sat, 23 Feb 2008 10:40:38 -0800 [thread overview]
Message-ID: <20080223104038.0599a30d.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080223113724.GB31304@elte.hu>
On Sat, 23 Feb 2008 12:37:24 +0100 Ingo Molnar <mingo@elte.hu> wrote:
> * Andrew Morton <akpm@linux-foundation.org> wrote:
>
> > > Sysprof needs a 200 line kernel module to do it's work, this module
> > > puts some simple profiling data into debugfs.
> > >
> > > ...
> >
> > Seems a poor idea to me. Sure, oprofile is "hard to set up", but not
> > if your distributor already did it for you.
>
> two things.
>
> Firstly, this isnt an oprofile replacement, this is a pretty separate
> concept. Sysprof is more of a tracer than a profiler.
I don't understand the distinction and I don't see what sysprof (as defined
by its kernel->userspace interface) can do which oprofile cannot.
This is yet another thing which should have been in the damned changlog but
wasn't.
> (and we are
> currently working on merging it into ftrace)
I think you should drop it and we should see a replacement patch which has
all the bugs, inefficiencies and deficiencies addressed and which has a
vaguely respectable description.
> Secondly, real developers who tune user-space code disagree with your
> characterisation of oprofile being easy to use.
afacit all of these criticisms surround oprofile's userspace tools only.
next prev parent reply other threads:[~2008-02-23 18:43 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-19 20:37 [PATCH] x86: add the debugfs interface for the sysprof tool Arjan van de Ven
2008-02-20 9:10 ` Ingo Molnar
2008-02-26 4:13 ` Anton Blanchard
2008-02-26 8:57 ` Ingo Molnar
2008-02-20 18:16 ` Peter Zijlstra
2008-02-20 18:39 ` Arjan van de Ven
2008-02-20 18:53 ` Peter Zijlstra
2008-02-20 18:58 ` Peter Zijlstra
2008-02-26 5:03 ` Anton Blanchard
2008-02-20 19:26 ` Arjan van de Ven
2008-02-20 20:58 ` Peter Zijlstra
2008-02-20 21:07 ` Arjan van de Ven
2008-02-20 21:44 ` Peter Zijlstra
2008-02-20 22:36 ` Arjan van de Ven
2008-02-23 8:11 ` Andrew Morton
2008-02-23 11:37 ` Ingo Molnar
2008-02-23 13:53 ` John Levon
2008-02-23 15:50 ` Ingo Molnar
2008-02-23 20:15 ` Soeren Sandmann
2008-02-23 20:42 ` Andrew Morton
2008-02-26 5:13 ` Anton Blanchard
2008-02-26 9:02 ` Ingo Molnar
2008-02-26 17:29 ` Andrew Morton
2008-02-27 14:05 ` Anton Blanchard
2008-02-24 13:10 ` Theodore Tso
2008-02-24 13:44 ` Ingo Molnar
2008-02-24 14:33 ` Ingo Molnar
2008-02-24 16:32 ` John Levon
2008-02-24 18:19 ` Theodore Tso
2008-02-23 18:40 ` Andrew Morton [this message]
2008-02-23 11:51 ` Pekka Enberg
2008-02-23 12:22 ` Ingo Molnar
2008-02-23 12:29 ` Pekka Enberg
2008-02-23 18:46 ` Andrew Morton
2008-02-24 2:49 ` Pekka Enberg
2008-02-24 3:12 ` Nicholas Miell
2008-02-26 6:27 ` Pekka Enberg
2008-02-26 6:48 ` Pekka Enberg
2008-02-26 8:55 ` Ingo Molnar
2008-02-23 14:54 ` Pekka Enberg
2008-02-23 19:01 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080223104038.0599a30d.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=hpa@zytor.com \
--cc=levon@movementarian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sandmann@redhat.com \
--cc=tglx@tglx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox