From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: VT notifier fix for VT switch
Date: Sat, 23 Feb 2008 14:46:21 +0100 [thread overview]
Message-ID: <20080223134621.GF4244@implementation> (raw)
In-Reply-To: <20080223000430.074b3648.akpm@linux-foundation.org>
Andrew Morton, le Sat 23 Feb 2008 00:04:30 -0800, a écrit :
> On Thu, 21 Feb 2008 21:26:40 +0100 Samuel Thibault <samuel.thibault@ens-lyon.org> wrote:
>
> > Notify when VT switch is complete.
> >
> > Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> >
> > --- linux-2.6.24-orig/drivers/char/vt.c 2008-01-25 09:32:06.000000000 +0100
> > +++ linux-2.6.24-perso/drivers/char/vt.c 2008-02-21 15:51:13.000000000 +0100
> > @@ -702,6 +702,7 @@
> > if (is_switch) {
> > set_leds();
> > compute_shiftstate();
> > + notify_update(vc);
> > }
> > }
> >
>
> The changelog is too terse, sorry. What is the reason for making this
> change? What are the user-visible effects of not having this change?
Ok:
VT notifier callbacks need to be aware of console switches. This
is already partially done from console_callback(), but at that time
fg_console, cursor positions, etc. are not yet updated and hence screen
readers fetch the old values.
This adds an update notify after all of the values are updated in
redraw_screen(vc, 1).
> If it fixes a bug, should it be backported to 2.6.24.x and earlier?
It would be useful to backport it to 2.6.24.x indeed. Earlier versions
don't have VT notifiers.
Samuel
prev parent reply other threads:[~2008-02-23 13:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 20:26 VT notifier fix for VT switch Samuel Thibault
2008-02-23 8:04 ` Andrew Morton
2008-02-23 13:46 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080223134621.GF4244@implementation \
--to=samuel.thibault@ens-lyon.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox