* VT notifier fix for VT switch
@ 2008-02-21 20:26 Samuel Thibault
2008-02-23 8:04 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Samuel Thibault @ 2008-02-21 20:26 UTC (permalink / raw)
To: linux-kernel, akpm
Notify when VT switch is complete.
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
--- linux-2.6.24-orig/drivers/char/vt.c 2008-01-25 09:32:06.000000000 +0100
+++ linux-2.6.24-perso/drivers/char/vt.c 2008-02-21 15:51:13.000000000 +0100
@@ -702,6 +702,7 @@
if (is_switch) {
set_leds();
compute_shiftstate();
+ notify_update(vc);
}
}
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: VT notifier fix for VT switch
2008-02-21 20:26 VT notifier fix for VT switch Samuel Thibault
@ 2008-02-23 8:04 ` Andrew Morton
2008-02-23 13:46 ` Samuel Thibault
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2008-02-23 8:04 UTC (permalink / raw)
To: Samuel Thibault; +Cc: linux-kernel
On Thu, 21 Feb 2008 21:26:40 +0100 Samuel Thibault <samuel.thibault@ens-lyon.org> wrote:
> Notify when VT switch is complete.
>
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
>
> --- linux-2.6.24-orig/drivers/char/vt.c 2008-01-25 09:32:06.000000000 +0100
> +++ linux-2.6.24-perso/drivers/char/vt.c 2008-02-21 15:51:13.000000000 +0100
> @@ -702,6 +702,7 @@
> if (is_switch) {
> set_leds();
> compute_shiftstate();
> + notify_update(vc);
> }
> }
>
The changelog is too terse, sorry. What is the reason for making this
change? What are the user-visible effects of not having this change? If
it fixes a bug, should it be backported to 2.6.24.x and earlier?
etcetera.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: VT notifier fix for VT switch
2008-02-23 8:04 ` Andrew Morton
@ 2008-02-23 13:46 ` Samuel Thibault
0 siblings, 0 replies; 3+ messages in thread
From: Samuel Thibault @ 2008-02-23 13:46 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
Andrew Morton, le Sat 23 Feb 2008 00:04:30 -0800, a écrit :
> On Thu, 21 Feb 2008 21:26:40 +0100 Samuel Thibault <samuel.thibault@ens-lyon.org> wrote:
>
> > Notify when VT switch is complete.
> >
> > Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> >
> > --- linux-2.6.24-orig/drivers/char/vt.c 2008-01-25 09:32:06.000000000 +0100
> > +++ linux-2.6.24-perso/drivers/char/vt.c 2008-02-21 15:51:13.000000000 +0100
> > @@ -702,6 +702,7 @@
> > if (is_switch) {
> > set_leds();
> > compute_shiftstate();
> > + notify_update(vc);
> > }
> > }
> >
>
> The changelog is too terse, sorry. What is the reason for making this
> change? What are the user-visible effects of not having this change?
Ok:
VT notifier callbacks need to be aware of console switches. This
is already partially done from console_callback(), but at that time
fg_console, cursor positions, etc. are not yet updated and hence screen
readers fetch the old values.
This adds an update notify after all of the values are updated in
redraw_screen(vc, 1).
> If it fixes a bug, should it be backported to 2.6.24.x and earlier?
It would be useful to backport it to 2.6.24.x indeed. Earlier versions
don't have VT notifiers.
Samuel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-02-23 13:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-21 20:26 VT notifier fix for VT switch Samuel Thibault
2008-02-23 8:04 ` Andrew Morton
2008-02-23 13:46 ` Samuel Thibault
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox