Re: [PATCH] [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

[Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>]

On Fri, Feb 22, 2008 at 11:25:04AM -0800, Randy Dunlap wrote:
> Let's see what the ACPI people think about this change.
> 
> Thanks, Sam.
> ---
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Make ACPI_CUSTOM_DSDT boolean config symbol a hidden and derived
> value, based on the value of ACPI_CUSTOM_DSDT_FILE (string).
> Only the latter is presented to the user as a config option.
> 
> This fixes problems with "make randconfig" setting ACPI_CUSTOM_DSDT
> but leaving ACPI_CUSTOM_DSDT_FILE empty/blank.
> 
Thanks, the patch solves the build failure.

Tested-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/acpi/Kconfig |   19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

--- linux-2.6.25-rc2-git5.orig/drivers/acpi/Kconfig
+++ linux-2.6.25-rc2-git5/drivers/acpi/Kconfig
@@ -283,24 +283,23 @@ config ACPI_TOSHIBA
        If you have a legacy free Toshiba laptop (such as the Libretto
L1
        series), say Y.

-config ACPI_CUSTOM_DSDT
-     bool "Include Custom DSDT"
+config ACPI_CUSTOM_DSDT_FILE
+     string "Custom DSDT Table file to include"
+     default ""
      depends on !STANDALONE
-     default n 
      help
        This option supports a custom DSDT by linking it into the
kernel.
        See Documentation/acpi/dsdt-override.txt

-       If unsure, say N.
-
-config ACPI_CUSTOM_DSDT_FILE
-     string "Custom DSDT Table file to include"
-     depends on ACPI_CUSTOM_DSDT
-     default ""
-     help
        Enter the full path name to the file which includes the AmlCode
        declaration.

+       If unsure, don't enter a file name.
+
+config ACPI_CUSTOM_DSDT
+     bool
+     default ACPI_CUSTOM_DSDT_FILE != ""
+
 config ACPI_CUSTOM_DSDT_INITRD
      bool "Read Custom DSDT from initramfs"
      depends on BLK_DEV_INITRD

After applying the patch and continuing with the same randconfig
reported earlier, the build fails with following error

drivers/acpi/thermal.c: In function ‘acpi_thermal_init’:
drivers/acpi/thermal.c:1792: error: ‘thermal_dmi_table’ undeclared (first use in this function)
drivers/acpi/thermal.c:1792: error: (Each undeclared identifier is reported only once
drivers/acpi/thermal.c:1792: error: for each function it appears in.)
make[2]: *** [drivers/acpi/thermal.o] Error 1
make[1]: *** [drivers/acpi] Error 2
make: *** [drivers] Error 2

I have tested the patch for build failure only.

Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
--
--- linux-2.6.25-rc2/drivers/acpi/Kconfig	2008-02-23 19:54:11.000000000 +0530
+++ linux-2.6.25-rc2/drivers/acpi/~Kconfig	2008-02-24 04:16:07.000000000 +0530
@@ -187,7 +187,7 @@ config ACPI_HOTPLUG_CPU
 
 config ACPI_THERMAL
 	tristate "Thermal Zone"
-	depends on ACPI_PROCESSOR
+	depends on ACPI_PROCESSOR && DMI
 	select THERMAL
 	default y
 	help
-- 
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.