[PATCH] Change a WARN message in checkpatch

Paolo Ciarrocchi
2008-01-04T12:45:53Z

Hi Andy,
I just started using checkpatch and I was confused by the following WARN message:

no space between function name and open parenthesis

I thought the probelm was that a space was missing while the truth is the opposite.

How about the following patch?

--- checkpatch.pl.old 2008-01-04 13:37:51.000000000 +0100
+++ checkpatch.pl 2008-01-04 13:37:24.000000000 +0100
@@ -1117,7 +1117,7 @@
while ($line =~ /($Ident)\s+\(/g) {
if ($1 !~ /^(?:if|for|while|switch|return|volatile|__volatile__|__attribute__|format|__extension__|Copyright|case)$/ &&
$line !~ /$Type\s+\(/ && $line !~ /^.\#\s*define\b/) {
- WARN("no space between function name and open parenthesis '('\n" . $herecurr);
+ WARN("don't put a space between function name and open parenthesis '('\n" . $herecurr);
}
}
# Check operator spacing.