Re: x86: geode: MSR cleanup

["Jordan Crouse" <jordan.crouse@amd.com>]

On 24/02/08 18:33 -0500, Andres Salomon wrote:
> Note that I didn't bother cleaning up the gxfb and lxfb headers wrt MSRs;
> that's coming in another patch (which is still in progress).
> 
> 
> From 22b8ddf47f77f01a59afb937779f4c83e9862f9e Mon Sep 17 00:00:00 2001
> From: Andres Salomon <dilinger@debian.org>
> Date: Sun, 24 Feb 2008 13:14:57 -0500
> Subject: [PATCH] x86: geode: MSR cleanup
> 
> This cleans up a few MSR-using drivers in the following manner:
>   - Ensures MSRs are all defined in asm/geode.h, rather than in misc
>     places
>   - Makes the naming consistent; cs553[56] ones begin with MSR_,
>     GX-specific ones start with MSR_GX_, and LX-specific ones start
>     with MSR_LX_.  Also, make the names match the data sheet.
>   - Use MSR names rather than numbers in source code
>   - Document the fact that the LX's MSR_PADSEL has the wrong value
>     in the data sheet.  That's, uh, good to note.
> 
> Signed-off-by: Andres Salomon <dilinger@debian.org>

Acked-by: Jordan Crouse <jordan.crouse@amd.com>

Thanks for doing this - I'm always happy when stuff gets scratched off my
TODO list automatically.