Re: [PATCH] Fix alignment of early reservation for EBDA

Andi Kleen
2008-02-27T14:23:35Z

Alexander van Heukelum wrote:
> On Sun, 24 Feb 2008 18:18:16 -0800, "H. Peter Anvin" <hpa@zytor.com>
> said:
>> Alexander van Heukelum wrote:
>>> early res: 3 [9f000-9ffff] EBDA
>>>
>>> Is it really necessary to force the allocation to a page boundary?
>> It is, but that rounding gets done in reserve_bootmem() anyway, so there
>> is no need for the arch-specific code to do it.
>>
>> The 32-bit EBDA code hard-codes a size of 4K, which is probably equally
>> wrong; my gut feel is that the right thing to do is to reserve from the
>> EBDA up to the 640K mark (some BIOSes use an area like that for SMM
>> stuff), possibly with some sanity checking.

It's not needed, the e820 maps are always correct for modern systems in
this case as far as I know.

>
> /* reserve all memory between lowmem and the 1MB mark */
> reserve_early(lowmem, 0x100000, "BIOS reserved");

The i386 kernel did this always, but I intentionally removed it from the
64bit kernel because all the modern BIOS seem to correctly report holes
in this area. Only didn't do it on i386 because there were some concerns
of very old systems not doing this correctly.

My suspicion is that modern Windows systems rely on this, that is why
BIOSes typically get it correct now.

I think it should be only undone if you have a concrete case where it
breaks not just based on someone's gut feel. Sure it's not a lot of
memory, but why waste memory unnecessarily?

-Andi