From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: Anton Vorontsov <cbouatmailru@gmail.com>
Cc: Matt Reimer <mreimer@vpop.net>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/2] [W1] ds1wm: should check for IS_ERR(clk) instead of NULL
Date: Tue, 26 Feb 2008 01:26:17 +0300 [thread overview]
Message-ID: <20080225222617.GA11899@2ka.mipt.ru> (raw)
In-Reply-To: <20080225212426.GA29891@zarina>
Hi Anton.
On Tue, Feb 26, 2008 at 12:24:26AM +0300, Anton Vorontsov (cbouatmailru@gmail.com) wrote:
> On the error condition clk_get() returns ERR_PTR(..), so checking
> for NULL doesn't work. ds1wm module causes a kernel oops when ds1wm
> clock isn't registered.
>
> This patch converts NULL check to IS_ERR(), plus uses PTR_ERR()
> for the return code.
>
> Signed-off-by: Anton Vorontsov <cbouatmailru@gmail.com>
Both patches look good, thanks Anton.
Andrew, please merge them and add my ack if needed.
Thank you.
--
Evgeniy Polyakov
prev parent reply other threads:[~2008-02-25 22:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-25 21:24 [PATCH 1/2] [W1] ds1wm: should check for IS_ERR(clk) instead of NULL Anton Vorontsov
2008-02-25 22:26 ` Evgeniy Polyakov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080225222617.GA11899@2ka.mipt.ru \
--to=johnpol@2ka.mipt.ru \
--cc=akpm@linux-foundation.org \
--cc=cbouatmailru@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mreimer@vpop.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox