Re: [PATCH] x86: add the debugfs interface for the sysprof tool

[Anton Blanchard <anton@samba.org>]

 
> > From: Soren Sandmann <sandmann@redhat.com>
> > Subject: [PATCH] x86: add the debugfs interface for the sysprof tool
> > 
> > The sysprof tool is a very easy to use GUI tool to find out where 
> > userspace is spending CPU time. See 
> > http://www.daimi.au.dk/~sandmann/sysprof/ for more information and 
> > screenshots on this tool.
> > 
> > Sysprof needs a 200 line kernel module to do it's work, this module 
> > puts some simple profiling data into debugfs.
> 
> thanks, looks good to me - applied.

Woah slow down guys. Did I miss the review?

Yes it's a 200 line patch, but it's a 200 line x86 patch. Surely we
should apply some of the same rigour we did when we merged the oprofile
patch? Is it biarch safe? Will it run on powerpc, arm etc?

I'm still struggling to understand why we need this functionality at
all. Lets argue the ABI and not cloud it with a discussion about
userspace eye candy. What does this give you that is an improvement over
the oprofile kernel-user ABI?

Anton