From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <Yinghai.Lu@Sun.COM>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Greg KH <greg@kroah.com>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86_64: force re setting the mmconf for fam10h if acpi=off
Date: Tue, 26 Feb 2008 08:24:52 +0100 [thread overview]
Message-ID: <20080226072451.GD24820@elte.hu> (raw)
In-Reply-To: <200802251841.36135.yinghai.lu@sun.com>
* Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:
> some BIOS only let AMD fam 10h handle bus0, and nvidia mcp55/ck804 to
> handle other buses. at that case MCFG will cover all over them.
>
> but with acpi=off, we can not use MCFG. this patch will double check
> the busnbits, and if it is less handling 256 bues, and acpi=off will
> forcely reset the mmconf in msr, so we still use mmconf in above case.
thanks, applied.
> @@ -720,14 +720,21 @@ static void __cpuinit fam10h_check_enabl
btw., a cleanliness suggestion: wouldnt it be cleaner to separate all
the extra AMD family 16 code into a separate file? That should make it
more focused and more isolated as well.
Ingo
next prev parent reply other threads:[~2008-02-26 7:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-26 2:41 [PATCH] x86_64: force re setting the mmconf for fam10h if acpi=off Yinghai Lu
2008-02-26 7:24 ` Ingo Molnar [this message]
2008-02-26 19:04 ` [PATCH] x86_64: Seperate mmconf for fam10h out from setup_64.c Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080226072451.GD24820@elte.hu \
--to=mingo@elte.hu \
--cc=Yinghai.Lu@Sun.COM \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox