public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: petkovbb@gmail.com
Cc: Andreas Schwab <schwab@suse.de>,
	Kiyoshi Ueda <k-ueda@ct.jp.nec.com>,
	linux-kernel@vger.kernel.org, jens.axboe@oracle.com,
	j-nomura@ce.jp.nec.com
Subject: Re: 2.6.25-rc1/2 CD/DVD burning broken
Date: Tue, 26 Feb 2008 21:01:53 +0100	[thread overview]
Message-ID: <200802262101.53706.bzolnier@gmail.com> (raw)
In-Reply-To: <20080226173855.GA5497@gollum.tnic>

On Tuesday 26 February 2008, Borislav Petkov wrote:
> On Tue, Feb 26, 2008 at 03:52:13PM +0100, Andreas Schwab wrote:
> > Borislav Petkov <petkovbb@googlemail.com> writes:
> > 
> > > On Mon, Feb 25, 2008 at 11:08:55PM +0100, Andreas Schwab wrote:
> > >> Borislav Petkov <petkovbb@googlemail.com> writes:
> > >> 
> > >> > On Mon, Feb 25, 2008 at 08:38:22PM +0100, Andreas Schwab wrote:
> > >> >> "Kiyoshi Ueda" <k-ueda@ct.jp.nec.com> writes:
> > >> >> 
> > >> >> > I'm looking at this problem, but currently no idea why the conversion
> > >> >> > to blk_end_request causes it.
> > >> >> 
> > >> >> cdrom_newpc_intr apparently never sets rq->sense_len.
> > >> >> 
> > >> >
> > >> > actually it does, see the code chunk around line 1188 in 2.6.25-rc2, for
> > >> > example.
> > >> 
> > >> Yes, it does, but it always adds zero.
> > >
> > > yep, true. Does that fix your dvd burning problem?
> > 
> > Yes, sure.
> > 
> > Andreas.
> 
> Bart,
> 
> please apply the enclosed patch since it fixes dvd burning with growisofs on
> Pioneer drives as reported by Andreas.
> 
> Thanks.
> 
> ---
> From: Andreas Schwab <schwab@suse.de>
> 
> Move counting of sense bytes into the transfer loop.
> 
> Signed-off-by: Andreas Schwab <schwab@suse.de>
> Acked-by: Borislav Petkov <petkovbb@gmail.com>

applied, thanks!

  reply	other threads:[~2008-02-26 22:24 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-16 20:52 2.6.25-rc1/2 CD/DVD burning broken Andreas Schwab
2008-02-17  0:09 ` Jeff Garzik
2008-02-17  0:48   ` Andreas Schwab
2008-02-17  3:57     ` Mark Lord
2008-02-17  9:33       ` Andreas Schwab
2008-02-18 15:59 ` Bartlomiej Zolnierkiewicz
2008-02-18 18:58   ` Kiyoshi Ueda
2008-02-18 19:55     ` Laura Garcia
2008-02-18 20:19     ` Andreas Schwab
2008-02-18 20:20     ` Borislav Petkov
2008-02-18 22:37       ` Borislav Petkov
2008-02-18 23:14         ` [PATCH] ide-cd: fix missing residual count setting in DMA mode (Was 2.6.25-rc1/2 CD/DVD burning broken) Kiyoshi Ueda
2008-02-19  0:17           ` Bartlomiej Zolnierkiewicz
2008-02-23 15:47     ` 2.6.25-rc1/2 CD/DVD burning broken Andreas Schwab
2008-02-24 16:32       ` Borislav Petkov
2008-02-24 16:59         ` Andreas Schwab
2008-02-25  2:49           ` Kiyoshi Ueda
2008-02-25  9:23             ` Andreas Schwab
2008-02-25 19:38             ` Andreas Schwab
2008-02-25 20:45               ` Borislav Petkov
2008-02-25 22:08                 ` Andreas Schwab
2008-02-26  4:24                   ` Borislav Petkov
2008-02-26 14:52                     ` Andreas Schwab
2008-02-26 17:38                       ` Borislav Petkov
2008-02-26 20:01                         ` Bartlomiej Zolnierkiewicz [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-02-17 23:21 Joerg Schilling
2008-02-17 23:51 ` Jan Engelhardt
2008-02-18 11:28   ` Joerg Schilling
2008-02-18 11:32     ` Jan Engelhardt
2008-02-18  8:46 ` Frans Pop
2008-02-18  8:56   ` Mike Galbraith
2008-02-18 10:31     ` Frans Pop
2008-02-18 11:41       ` Mike Galbraith
2008-02-18 23:27       ` Jan Engelhardt
2008-02-28 18:41   ` Bill Davidsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802262101.53706.bzolnier@gmail.com \
    --to=bzolnier@gmail.com \
    --cc=j-nomura@ce.jp.nec.com \
    --cc=jens.axboe@oracle.com \
    --cc=k-ueda@ct.jp.nec.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=petkovbb@gmail.com \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox