From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759481AbYB0Ugg (ORCPT ); Wed, 27 Feb 2008 15:36:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757436AbYB0Ug2 (ORCPT ); Wed, 27 Feb 2008 15:36:28 -0500 Received: from ra.tuxdriver.com ([70.61.120.52]:4237 "EHLO ra.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757432AbYB0Ug2 (ORCPT ); Wed, 27 Feb 2008 15:36:28 -0500 Date: Wed, 27 Feb 2008 15:15:50 -0500 From: "John W. Linville" To: Larry Finger Cc: Alexey Zaytsev , Stefano Brivio , Jeff Garzik , Greg KH , Pekka Enberg , Ingo Molnar , Michael Buesch , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fix the bcm43xx driver breakage in 2.6.24/25. Message-ID: <20080227201550.GG3078@tuxdriver.com> References: <47C01D03.9030601@gmail.com> <47C19ABA.4040904@lwfinger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47C19ABA.4040904@lwfinger.net> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 24, 2008 at 09:26:34AM -0700, Larry Finger wrote: > I have reviewed the above patches and tested them with what I believe to be > most combinations. Everything worked and corrected the unintended > consequence of breaking bcm43xx when b44 is included. I agree that these > patches belong in 2.6.25 and stable (2.6.24). Of course, the problem goes > away in 2.6.26. I can't say I really like Alexey's patches, but I guess they are OK. I think I like the "b43_pci_bridge as a module" option a little better, but as Michael illustrated there are problems with that approach too. I'll apply the patches. John -- John W. Linville linville@tuxdriver.com