From: Paul Jackson <pj@sgi.com>
To: "Paul Menage" <menage@google.com>
Cc: containers@lists.osdl.org, linux-kernel@vger.kernel.org,
balbir@linux.vnet.ibm.com, a.p.zijlstra@chello.nl,
xemul@openvz.org, akpm@linux-foundation.org
Subject: Re: [RFC] Prefixing cgroup generic control filenames with "cgroup."
Date: Thu, 28 Feb 2008 19:22:32 -0600 [thread overview]
Message-ID: <20080228192232.b2211b4d.pj@sgi.com> (raw)
In-Reply-To: <6599ad830802281703hb3cff06r8ba4755f705a0879@mail.gmail.com>
> Subsystem-created files already have an appropriate prefix.
Good ... such little consistencies in naming are helpful, when
voluntarily self imposed, without incompatible changes to published
names.
> > No need to
> > change the existing well known names for this reason.
>
> But that's part of my point - is it reasonable to describe a system
> that was only introduced in 2.6.24 as "well-known"?
In their earlier cpuset context, "tasks" and "notify_on_release" have
been well known for years.
And breaking actual compatibility, in a way that will break more than
the tiniest set of users, even over one release, should not be done
without both (1) a really good cause, and (2) a plan for migrating
users over a couple of releases to the new interface.
> > back much earlier than that. Please don't rename these two files in
> > cgroups; and of course absolutely don't rename them in cpusets.
>
> No, I wasn't planning to make any changes to cpusets.
Yeah - I figured you wouldn't risk my wrath changing this in cpusets ;).
Could you please not change them in cgroups, either?
> > Please don't end up with different names of these files, depending on
> > whether you're in cgroups or cpusets, either.
>
> That already happens - when mounted as the "cpuset" filesystem, we
> have names like "mems_allowed". When mounted as cgroups, we have names
> like cpuset.mems_allowed.
Ok - it does make sense that cpuset specific files, when embedded in the
more general purpose cgroups, are adorned with name prefixes that they
didn't have in the legacy API. And besides, it is what is -- we released
it, and there's no compelling disaster forcing a change.
But generic cgroup infrastructure files, such as "tasks", have not had
such adornments. And now, that is what it is -- released, and sufficient
to remain as it is.
> No, I don't like that idea either.
Good (and extra credit for saying so with fewer words and more politely
than I managed ;).
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.940.382.4214
next prev parent reply other threads:[~2008-02-29 1:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-28 21:14 [RFC] Prefixing cgroup generic control filenames with "cgroup." Paul Menage
2008-02-28 21:21 ` Andrew Morton
2008-02-28 21:28 ` Paul Menage
2008-02-28 21:33 ` serge
2008-02-28 22:06 ` Paul Menage
2008-03-03 8:38 ` Paul Menage
2008-03-03 9:59 ` Balbir Singh
2008-02-28 21:40 ` Andrew Morton
2008-02-28 22:06 ` Paul Menage
2008-02-28 22:21 ` Andrew Morton
2008-02-28 22:26 ` Paul Menage
2008-02-29 5:59 ` [RFC] [PATCH] " Paul Menage
2008-02-29 6:20 ` Paul Jackson
2008-02-29 9:34 ` Paul Menage
2008-02-29 15:30 ` Paul Jackson
2008-02-29 17:59 ` Paul Menage
2008-02-29 19:20 ` Paul Jackson
2008-02-28 21:28 ` [RFC] " serge
2008-02-28 23:36 ` Paul Jackson
2008-02-29 1:03 ` Paul Menage
2008-02-29 1:22 ` Paul Jackson [this message]
2008-02-29 11:38 ` Xpl++
2008-03-03 7:23 ` Li Zefan
2008-03-03 9:11 ` Paul Menage
2008-03-05 1:24 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080228192232.b2211b4d.pj@sgi.com \
--to=pj@sgi.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=containers@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox