public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ed Tomlinson <edt@aei.ca>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Panic 2.6.24-3 NMI Watchdog detected LOCKUP on CPU 0
Date: Mon, 3 Mar 2008 08:17:02 -0500	[thread overview]
Message-ID: <200803030817.03680.edt@aei.ca> (raw)
In-Reply-To: <alpine.LFD.1.00.0803011527410.11084@apollo.tec.linutronix.de>

Thomas,

I have booted many times over the weekend.  I've yet to trigger the watchdog.   Since I used to see problems 
in 1 in 3 or 4 boots,  I think you fixed the problem with patch below.

Thanks
Ed

On March 1, 2008, Thomas Gleixner wrote:
> On Sat, 1 Mar 2008, Ed Tomlinson wrote:
> > Hi,
> > 
> > I have been seeing these since I installed .24 kernels.  It does not seem to matter if I change the clocksource from tsc
> > to apci_pm.  Its happened with all .24 kernels I have tried starting with stock 2.6.24 upto 2.6.24-gentoo-r2 + 2.6.24-3
> > 
> > Ideas?
> 
> Questions first. Is there a particular reason to use idle=poll ?
> 
> Idea: does the patch below help ?
> 
> Thanks,
> 	tglx
> 
> ---
> 
>  arch/x86/kernel/process_64.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> Index: linux-2.6.24/arch/x86/kernel/process_64.c
> ===================================================================
> --- linux-2.6.24.orig/arch/x86/kernel/process_64.c
> +++ linux-2.6.24/arch/x86/kernel/process_64.c
> @@ -212,14 +212,13 @@ void cpu_idle (void)
>  	current_thread_info()->status |= TS_POLLING;
>  	/* endless idle loop with no priority at all */
>  	while (1) {
> +		tick_nohz_stop_sched_tick();
>  		while (!need_resched()) {
>  			void (*idle)(void);
>  
>  			if (__get_cpu_var(cpu_idle_state))
>  				__get_cpu_var(cpu_idle_state) = 0;
>  
> -			tick_nohz_stop_sched_tick();
> -
>  			rmb();
>  			idle = pm_idle;
>  			if (!idle)
> 
> 



  parent reply	other threads:[~2008-03-03 13:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-01 14:11 Panic 2.6.24-3 NMI Watchdog detected LOCKUP on CPU 0 Ed Tomlinson
2008-03-01 14:29 ` Thomas Gleixner
2008-03-01 14:38   ` Ed Tomlinson
2008-03-03 13:17   ` Ed Tomlinson [this message]
2008-03-03 13:22     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200803030817.03680.edt@aei.ca \
    --to=edt@aei.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox