From: Matthew Wilcox <matthew@wil.cx>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: linux-kernel@vger.kernel.org, Matthew Wilcox <willy@linux.intel.com>
Subject: Re: [PATCH 11/12] Generic semaphore implementation
Date: Mon, 3 Mar 2008 07:54:34 -0700 [thread overview]
Message-ID: <20080303145434.GH24386@parisc-linux.org> (raw)
In-Reply-To: <1204252679.20280.115.camel@brick>
On Thu, Feb 28, 2008 at 06:37:59PM -0800, Harvey Harrison wrote:
> > +/*
> > + * Because this function is inlined, the 'state' parameter will be constant,
> > + * and thus optimised away by the compiler.
> > + */
>
> If so, is unlikely() still needed?
It's needed for the case where the function is inlined into
__down_interruptible / __down_killable.
> Other than that small bit, looks great, any thoughts to getting rid of
> all the likely/unlikely as well? If they're no longer performance
> critical, it would be nice to have it that little bit cleaner.
I'd rather keep it as close to mutex.c as possible.
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
prev parent reply other threads:[~2008-03-03 14:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-27 0:36 [PATCHES] semaphore rewrite Matthew Wilcox
2008-02-28 6:33 ` [PATCH 01/12] Fix quota.h includes Matthew Wilcox
2008-02-28 6:33 ` [PATCH 02/12] Add semaphore.h to kernel_lock.c Matthew Wilcox
2008-02-28 6:33 ` [PATCH 03/12] arch: Remove unnecessary inclusions of asm/semaphore.h Matthew Wilcox
2008-02-28 6:33 ` [PATCH 04/12] net: " Matthew Wilcox
2008-02-28 6:33 ` [PATCH 05/12] drivers: " Matthew Wilcox
2008-02-28 6:33 ` [PATCH 06/12] fs: " Matthew Wilcox
2008-02-28 6:33 ` [PATCH 07/12] include: " Matthew Wilcox
2008-02-28 6:33 ` [PATCH 08/12] kernel: " Matthew Wilcox
2008-02-28 6:33 ` [PATCH 09/12] lib: " Matthew Wilcox
2008-02-28 6:33 ` [PATCH 10/12] security: " Matthew Wilcox
2008-02-28 6:34 ` [PATCH 11/12] Generic semaphore implementation Matthew Wilcox
2008-02-28 6:34 ` [PATCH 12/12] Convert asm/semaphore.h users to linux/semaphore.h Matthew Wilcox
2008-02-28 7:18 ` [PATCH 11/12] Generic semaphore implementation Ingo Molnar
2008-02-29 0:39 ` Matthew Wilcox
2008-02-29 0:50 ` Harvey Harrison
2008-02-29 1:43 ` Andrew Morton
2008-02-29 5:30 ` Matthew Wilcox
2008-02-29 17:42 ` Haavard Skinnemoen
2008-02-29 19:21 ` Ingo Molnar
2008-02-29 2:00 ` Stephen Rothwell
2008-02-29 2:10 ` Andrew Morton
2008-02-29 5:32 ` Matthew Wilcox
2008-02-29 6:43 ` Stephen Rothwell
2008-02-29 16:14 ` Linus Torvalds
2008-02-29 1:57 ` Andrew Morton
2008-02-29 5:43 ` Matthew Wilcox
2008-02-29 2:37 ` Harvey Harrison
2008-02-29 2:47 ` [PATCH] semaphore: remove likely/unlikely annotations Harvey Harrison
2008-03-03 14:54 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080303145434.GH24386@parisc-linux.org \
--to=matthew@wil.cx \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox