Re: [patch] Re: using long instead of atomic_t when only set/read is required

Mark Lord
2008-03-06T15:58:43Z

Linus Torvalds wrote:
>
> On Mon, 3 Mar 2008, Alan Stern wrote:
>> Consider a routine like the following:
>>
>> static task_struct *the_task;
>>
>> void store_task(void)
>> {
>> the_task = current;
>> }
>>
>> Is it possible to say whether readers examining "the_task" are
>> guaranteed to see a coherent value?
>
> Yes, we do depend on this. All the RCU stuff (and in general *anything*
> that depends on memory ordering as opposed to full locking, and we have
> quite a lot of it) is very fundamentally dependent on the fact that things
> like pointers get read and written atomically.
..

But also consider something like this:

void store_task(void)
{
*the_task = current;
}

In this case, there is no guarantee that the assignment
can be done atomically on all CPU types. Some RISC archs
(eg. MIPS R2xxx) require an (interruptible) instruction pair
to store values to a potentially unaligned address.

This was a BIG issue on a different system that I once worked on.

Cheers