Re: Bugs in MMC [was: [Bug 10030] Suspend doesn't work when SD card is inserted]

Pierre Ossman
2008-03-04T06:05:35Z

On Mon, 3 Mar 2008 13:59:37 -0800
David Brownell <david-b@pacbell.net> wrote:

>
> Card insert/remove events can be system wake events though. Which
> makes that restriction impractical.
>
> I think hosts need to be able to call mmc_detect_change() as soon as
> they see a stable signal. The MMC core can hold off handling that
> for a while, if it needs to wait until the code walking the device
> tree gets around to resuming that host. It's a lot more natural to
> hold off such stuff one time there than in N host drivers; especially
> since the MMC core already has such hold-off code.
>

That actually sorts itself out as the MMC core reprobes on wakeup, but I see your point. Right now things will work peachy if the controllers just make sure to disable their card detection logic before telling the core to suspend.

Rgds
--
-- Pierre Ossman

Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org