Re: [PATCH] lguest: include function prototypes

Rusty Russell
2008-03-04T01:35:11Z

On Thursday 14 February 2008 08:14:35 Harvey Harrison wrote:
> Fix for sparse warning
> arch/x86/lguest/boot.c:939:13: warning: symbol 'lguest_init' was not
> declared. Should it be static?
>
> Added a declaration to asm-x86/lguest.h and moved the extern arrays there
> as well. As an alternative to including asm/lguest.h directly, an
> include could be put in linux/lguest.h

Hi Harvey,

Thanks for the patch. Currently asm/lguest.h is used for the guest/host
interface definitions, while these are purely in-guest symbols. The standard
for these 'used from asm/declared in asm' seems to be to put the declarations
in the C file directly.

However, since this has already been applied to Linus' tree, it's fine.

Thanks!
Rusty.