From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Joe Perches <joe@perches.com>
Cc: Nicolas Pitre <nico@cam.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] include/asm-arm - use angle brackets for includes
Date: Wed, 5 Mar 2008 07:47:23 +0000 [thread overview]
Message-ID: <20080305074723.GA19674@flint.arm.linux.org.uk> (raw)
In-Reply-To: <1204677978.5180.90.camel@localhost>
To: Russell King <rmk+kernel@arm.linux.org.uk>, Nicolas Pitre <nico@cam.org>
Cc: linux-arm-kernel@lists.arm.linux.org.uk,
LKML <linux-kernel@vger.kernel.org>
No idea why you're sending this to Nicolas, yet it touches s3cXXXX stuff
which is Ben Dooks, who has been omitted from the above.
On Tue, Mar 04, 2008 at 04:46:18PM -0800, Joe Perches wrote:
> Signed-off-by: Joe Perches <joe@perches.com
This is not a proper signed off - please use both angle brackets. 8)
>
> include/asm-arm/plat-s3c/uncompress.h | 4 ++--
> include/asm-arm/proc-fns.h | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/asm-arm/plat-s3c/uncompress.h b/include/asm-arm/plat-s3c/uncompress.h
> index b5e6208..19b9eda 100644
> --- a/include/asm-arm/plat-s3c/uncompress.h
> +++ b/include/asm-arm/plat-s3c/uncompress.h
> @@ -27,8 +27,8 @@ static void arch_detect_cpu(void);
>
> /* defines for UART registers */
>
> -#include "asm/plat-s3c/regs-serial.h"
> -#include "asm/plat-s3c/regs-watchdog.h"
> +#include <asm/plat-s3c/regs-serial.h>
> +#include <asm/plat-s3c/regs-watchdog.h>
>
> /* working in physical space... */
> #undef S3C2410_WDOGREG
> diff --git a/include/asm-arm/proc-fns.h b/include/asm-arm/proc-fns.h
> index a4ce457..75ec760 100644
> --- a/include/asm-arm/proc-fns.h
> +++ b/include/asm-arm/proc-fns.h
> @@ -214,9 +214,9 @@
> #ifndef __ASSEMBLY__
>
> #ifndef MULTI_CPU
> -#include "asm/cpu-single.h"
> +#include <asm/cpu-single.h>
> #else
> -#include "asm/cpu-multi32.h"
> +#include <asm/cpu-multi32.h>
> #endif
>
> #include <asm/memory.h>
>
>
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2008-03-05 7:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-05 0:46 [PATCH] include/asm-arm - use angle brackets for includes Joe Perches
2008-03-05 7:47 ` Russell King [this message]
2008-03-05 16:44 ` Joe Perches
2008-03-06 9:13 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080305074723.GA19674@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox