Re: [PATCH 11/11] memstick: add support for JMicron jmb38x MemoryStick host controller

Andrew Morton
2008-03-05T23:18:22Z

On Wed, 5 Mar 2008 03:02:28 +1100
oakad@exemail.com.au wrote:

> +static void jmb38x_ms_reset(struct jmb38x_ms_host *host)
> +{
> + unsigned int host_ctl = readl(host->addr + HOST_CONTROL);
> +
> + writel(host_ctl | HOST_CONTROL_RESET_REQ | HOST_CONTROL_RESET,
> + host->addr + HOST_CONTROL);
> +
> + while (HOST_CONTROL_RESET_REQ
> + & (host_ctl = readl(host->addr + HOST_CONTROL))) {

host_ctl is written to but is not used again.

> + ndelay(100);
> + dev_dbg(&host->chip->pdev->dev, "reset\n");
> + }
> +
> + writel(INT_STATUS_ALL, host->addr + INT_STATUS_ENABLE);
> + writel(INT_STATUS_ALL, host->addr + INT_SIGNAL_ENABLE);
> +
> + dev_dbg(&host->chip->pdev->dev, "reset\n");
> +}