Re: Linux 2.6.25-rc4

[Jonathan McDowell <noodles@earth.li>]

In article
<alpine.LFD.1.00.0803042044460.12253@woody.linux-foundation.org>
(earth.lists.linux-kernel) you wrote:

> It's a few days late, but I was waiting for some updates for some of the 
> most annoying regressions until releasing it, so the end result is 
> hopefully more useful as a result.

Still crashes in acpi_get_data for me; the patch mentioned
<1204241934.10256.151.camel@acpi-hp-zz.sh.intel.com> and tracked at

http://bugzilla.kernel.org/show_bug.cgi?id=10132

still doesn't seem to have hit mainline and still fixes the issue for me.

-----
From: Lin Ming <ming.m.lin@intel.com>

Fix a memory overflow bug when copying
NULL internal package element object to external.

Signed-off-by: Lin Ming <ming.m.lin@intel.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
---
 drivers/acpi/utilities/utobject.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6/drivers/acpi/utilities/utobject.c
===================================================================
--- linux-2.6.orig/drivers/acpi/utilities/utobject.c
+++ linux-2.6/drivers/acpi/utilities/utobject.c
@@ -432,7 +432,7 @@ acpi_ut_get_simple_object_size(union acp
         * element -- which is legal)
         */
        if (!internal_object) {
-               *obj_length = 0;
+               *obj_length = sizeof(union acpi_object);
                return_ACPI_STATUS(AE_OK);
        }

-----

J.

-- 
/-\                             | 101 things you can't have too much
|@/  Debian GNU/Linux Developer |     of : 8 - Hard drive space.
\-                              |