Re: [PATCH 5/9] Make use of permissions, returned by kobj_lookup

Pavel Emelyanov
2008-03-06T08:54:20Z

Andrew Morton wrote:
> On Wed, 05 Mar 2008 20:37:40 +0300
> Pavel Emelyanov <xemul@openvz.org> wrote:
>
>> diff --git a/include/linux/devscontrol.h b/include/linux/devscontrol.h
>> new file mode 100644
>> index 0000000..04c168b
>> --- /dev/null
>> +++ b/include/linux/devscontrol.h
>> @@ -0,0 +1,12 @@
>> +#ifndef __DEVS_CONTROL_H__
>> +#define __DEVS_CONTROL_H__
>> +static inline struct kobj_map *task_cdev_map(struct task_struct *tsk)
>> +{
>> + return NULL;
>> +}
>> +
>> +static inline struct kobj_map *task_bdev_map(struct task_struct *tsk)
>> +{
>> + return NULL;
>> +}
>> +#endif
>
> This doesn't include sufficient headers to be compileable.

Indeed :( The patch #9 actually declares two needed struct-s, so the final
compilation is clean, but this set is still bad from the git-bisect point
of view, sorry.

Shall I provide a devscontrol-make-use-of-permissions-returned-by-kobj_lookup-fix.patch
for this one? :)

> I'm sure there are lots of headers like this. But we regularly need
> to fix them.
>