Re: [PATCH 5/9] Make use of permissions, returned by kobj_lookup

Pavel Emelyanov
2008-03-07T09:29:05Z

Andrew Morton wrote:
> On Wed, 05 Mar 2008 20:37:40 +0300
> Pavel Emelyanov <xemul@openvz.org> wrote:
>
>> diff --git a/include/linux/devscontrol.h b/include/linux/devscontrol.h
>> new file mode 100644
>> index 0000000..04c168b
>> --- /dev/null
>> +++ b/include/linux/devscontrol.h
>> @@ -0,0 +1,12 @@
>> +#ifndef __DEVS_CONTROL_H__
>> +#define __DEVS_CONTROL_H__
>> +static inline struct kobj_map *task_cdev_map(struct task_struct *tsk)
>> +{
>> + return NULL;
>> +}
>> +
>> +static inline struct kobj_map *task_bdev_map(struct task_struct *tsk)
>> +{
>> + return NULL;
>> +}
>> +#endif
>
> This doesn't include sufficient headers to be compileable.
>
> I'm sure there are lots of headers like this. But we regularly need
> to fix them.
>

Not sure, whether this is still relevant after Greg's comments, but that's
the -fix patch for this one. (It will cause a conflict with the 9th patch.)

diff --git a/include/linux/devscontrol.h b/include/linux/devscontrol.h
index 04c168b..52cac64 100644
--- a/include/linux/devscontrol.h
+++ b/include/linux/devscontrol.h
@@ -1,5 +1,8 @@
#ifndef __DEVS_CONTROL_H__
#define __DEVS_CONTROL_H__
+struct kobj_map;
+struct task_struct;
+
static inline struct kobj_map *task_cdev_map(struct task_struct *tsk)
{
return NULL;