Re: [patch 2/2] x86, fpu: lazy allocation of FPU area - v3

Christoph Hellwig
2008-03-04T01:20:31Z

On Mon, Mar 03, 2008 at 03:02:46PM -0800, Suresh Siddha wrote:
> + /*
> + * Memory allocation at the first usage of the FPU and other state.
> + */
> + if (!tsk->thread.xstate)
> + tsk->thread.xstate = kmem_cache_alloc(task_xstate_cachep, GFP_KERNEL);

Please don't do over 80 char lines. Also don't we need some kind of
error handling here?