Re: [patch 1/2] x86, fpu: split FPU state from task struct - v3

Christoph Hellwig
2008-03-06T12:39:38Z

On Mon, Mar 03, 2008 at 05:36:49PM -0800, Suresh Siddha wrote:
> > You're still adding a second hook instead of re-using or re-naming
> > setup_thread_stack. Did I miss a good explanation for that
> > or was this just an oversight?
>
> Not an oversight. setup_thread_stack comes with its own baggage called
> __HAVE_THREAD_FUNCTIONS. Thought of keeping this simple and separate
> by using an inline or weak linkage.

Well, just switching setup_thread_stack to use whatever you use for your
current callout fixes that. I really don't want to arch callout doing
the same thing in almost the same place, this leads to twisted and
unreadable code. Please fix this last bit up and you'll get my full
ACK.