Re: [patch 2/2] x86, fpu: lazy allocation of FPU area - v3

Suresh Siddha
2008-03-04T01:43:19Z

On Mon, Mar 03, 2008 at 08:20:12PM -0500, Christoph Hellwig wrote:
> On Mon, Mar 03, 2008 at 03:02:46PM -0800, Suresh Siddha wrote:
> > + /*
> > + * Memory allocation at the first usage of the FPU and other state.
> > + */
> > + if (!tsk->thread.xstate)
> > + tsk->thread.xstate = kmem_cache_alloc(task_xstate_cachep, GFP_KERNEL);
>
> Please don't do over 80 char lines.

Ok.

> Also don't we need some kind of error handling here?

Currently it uses SLAB_PANIC.

thanks,
suresh