From: Andrew Morton <akpm@linux-foundation.org>
To: Matthias Kaehlcke <matthias@kaehlcke.net>
Cc: Daniel Walker <dwalker@mvista.com>,
linux-pcmcia@lists.infradead.org, linux-kernel@vger.kernel.org,
Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] Alchemy Semi Au1000 pcmcia driver: convert pcmcia_sockets_lock in a mutex
Date: Thu, 6 Mar 2008 23:38:04 -0800 [thread overview]
Message-ID: <20080306233804.4d13b637.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080307071342.GE2783@traven>
On Fri, 7 Mar 2008 08:13:42 +0100 Matthias Kaehlcke <matthias@kaehlcke.net> wrote:
> El Thu, Mar 06, 2008 at 07:05:49PM -0800 Daniel Walker ha dit:
>
> > On Thu, 2008-03-06 at 23:22 +0100, Matthias Kaehlcke wrote:
> > > Alchemy Semi Au1000 pcmcia driver: The semaphore pcmcia_sockets_lock
> > > is used as a mutex, convert it to the mutex API
> > >
> > > Signed-off-by: Matthias Kaehlcke <matthias@kaehlcke.net>
> > >
> >
> > This doesn't appear to be in patch format .. There no filename at the
> > top..
>
> somehow i messed it up when adding the patch to the mail. thanks for
> the pointer, here comes the good one
>
> --
>
> Alchemy Semi Au1000 pcmcia driver: The semaphore pcmcia_sockets_lock
> is used as a mutex, convert it to the mutex API
OK.
> @@ -71,7 +72,7 @@ extern struct au1000_pcmcia_socket au1000_pcmcia_socket[];
> u32 *pcmcia_base_vaddrs[2];
> extern const unsigned long mips_io_port_base;
>
> -DECLARE_MUTEX(pcmcia_sockets_lock);
> +DEFINE_MUTEX(pcmcia_sockets_lock);
I'll make this static while we're in there.
prev parent reply other threads:[~2008-03-07 7:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-06 22:22 [PATCH] Alchemy Semi Au1000 pcmcia driver: convert pcmcia_sockets_lock in a mutex Matthias Kaehlcke
2008-03-07 3:05 ` Daniel Walker
2008-03-07 7:13 ` Matthias Kaehlcke
2008-03-07 7:38 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080306233804.4d13b637.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=matthias@kaehlcke.net \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox